Fenix: [Bug]popup history white with dark theme

Created on 6 Nov 2020 · 6Comments · Source: mozilla-mobile/fenix

I cannot really believe how such visual incongruity is brought to fenix maybe it 's specific to nighty.
the popup panel that appears when long pressing back arrow in menu is blinding white even with dark theme enabled is not even possible to read tab name?!?!?!?!?!

Themes S2 engverified 🐞 bug

Source

ale82to

👍2

Most helpful comment

Verified as fixed on Nightly 12/16.

sflorean on 16 Dec 2020

🎉2

All 6 comments

Screenshots:

Firefox Nightly 20201106 05:02 dark theme
Firefox Nightly 20201106 05:02 dark theme - private browsing
Tor Browser 10.0.3 (based on Firefox 82.1.1)

| One URL in history | Two URLs |
| -------------------------------------------------------------------------------------------- | ------------------------------------------------------------ |
| Firefox Nightly 20201106 - Dark mode | |
| | |
| Tor Browser 10.0.3 (based on Firefox 82.1.1) | |

B0pol on 6 Nov 2020

I can confirm this issue for the dark mode.

LittleAngelwings on 6 Nov 2020

👍1

I can confirm the issue is reproducible Firefox Preview Nighlty 201111 (Build #2015775051)

Devices used:

OnePlus 6T (Android 9)
Samsung Galaxy S9 (Android 8.0.0)

LaurentiuApahideanSV on 12 Nov 2020

Did a quick test. This is the problematic commit. The material components update messes up the style thats set in TabHistoryDialogFragment. Don't have time to properly test a fix but hopefully this helps whoever looks at this.