Fenix: [Crash] ConcurrentModificationException org.mozilla.fenix.wifi.WifiConnectionMonitor

Created on 15 Oct 2020 · 8Comments · Source: mozilla-mobile/fenix

Followup to #14680

The main ObserverRegistry crash was resolved (see Sebastian's comment), but there is another related crash that we are seeing:

java.util.ConcurrentModificationException: null
    at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:757)
    at java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:780)
    at org.mozilla.fenix.wifi.WifiConnectionMonitor$frameworkListener$1.onAvailable(WifiConnectionMonitor.kt:2)
    at android.net.ConnectivityManager$NetworkCallback.onAvailable(ConnectivityManager.java:3322)
    at android.net.ConnectivityManager$CallbackHandler.handleMessage(ConnectivityManager.java:3607)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loop(Looper.java:223)
    at android.os.HandlerThread.run(HandlerThread.java:67)

Sentry: https://sentry.prod.mozaws.net/share/issue/4234e7770c9f4d05abd2c60f63aafb3c/

SitePermissions crash engverified help wanted

Source

eliserichards

All 8 comments

Managed to reproduce it on both 82.0.0-beta.6 and RC 82.1.0-rc1 using a OnePlus A3 (Android 6.0.1) on https://www.walkinto.in/tour/WyKhAFf0iXZJgF2CKzAj7

8346bcbb-5448-409b-97bd-f275bb46894e
java.util.ConcurrentModificationException

* Socorro: https://crash-stats.mozilla.org/report/index/bp-0b955d98-a872-4cfa-bd48-2e1900201016

java.util.ConcurrentModificationException
at java.util.LinkedHashMap$LinkedHashIterator.nextEntry(LinkedHashMap.java:346)
at java.util.LinkedHashMap$KeyIterator.next(LinkedHashMap.java:366)
at org.mozilla.fenix.wifi.WifiConnectionMonitor$frameworkListener$1.onAvailable(WifiConnectionMonitor.kt:2)
at android.net.ConnectivityManager$CallbackHandler.handleMessage(ConnectivityManager.java:2345)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:152)
at android.os.HandlerThread.run(HandlerThread.java:61)

AndiAJ on 16 Oct 2020

Looking at crash-stats for this (learned from kevin!), this looks pretty low incidence. However, if these are reliable steps to reproduce, this could be worthwhile to fix.

https://bugzilla.mozilla.org/show_bug.cgi?id=1644043

liuche on 17 Oct 2020

Managed to reproduce it on Firefox 82.1.2 using a OnePlus A3 (Android 6.0.1) on https://www.cbssports.com/

947c27bc-f053-4f8c-8ac4-df595242a581
java.util.ConcurrentModificationException

Sentry: https://sentry.prod.mozaws.net/operations/fenix-fennec/?query=8ff2eafb63e9413b82c55234bd9a70e0

* Socorro: https://crash-stats.mozilla.org/report/index/bp-abfc4259-9e8d-4a2a-a74d-8a4670201030

AndiAJ on 30 Oct 2020

The fix is should be in nightly now, QA team could please help us to verify? :)

Amejia481 on 6 Nov 2020

Managed to reproduce it on 83.0.0-beta.4 using a OnePlus A3 (Android 6.0.1) on https://www.walkinto.in/tour/WyKhAFf0iXZJgF2CKzAj7

ac633eb7-bdb4-438c-941e-100596597663
java.util.ConcurrentModificationException

Sentry: https://sentry.prod.mozaws.net/operations/fenix-fennec-beta/?query=af3bf350a66146eb8692b95d19d89909

* Socorro: https://crash-stats.mozilla.org/report/index/bp-d4ddc61c-a17e-4438-a50b-7ae720201109

AndiAJ on 9 Nov 2020

Managed to reproduce it on 83.0.0-beta.4 using a OnePlus A3 (Android 6.0.1) on https://www.walkinto.in/tour/WyKhAFf0iXZJgF2CKzAj7

ac633eb7-bdb4-438c-941e-100596597663
java.util.ConcurrentModificationException
* Sentry: https://sentry.prod.mozaws.net/operations/fenix-fennec-beta/?query=af3bf350a66146eb8692b95d19d89909

* Socorro: https://crash-stats.mozilla.org/report/index/bp-d4ddc61c-a17e-4438-a50b-7ae720201109
java.util.ConcurrentModificationException
at java.util.LinkedHashMap$LinkedHashIterator.nextEntry(LinkedHashMap.java:346)
at java.util.LinkedHashMap$KeyIterator.next(LinkedHashMap.java:366)
at org.mozilla.fenix.wifi.WifiConnectionMonitor$frameworkListener$1.onAvailable(WifiConnectionMonitor.kt:2)
at android.net.ConnectivityManager$CallbackHandler.handleMessage(ConnectivityManager.java:2345)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:152)
at android.os.HandlerThread.run(HandlerThread.java:61)

For the fix to be on 83.0.0-beta.4 we need to uplift the patch, before it, I just want to confirm @AndiAJ the issue is not reproducible in nightly?

Amejia481 on 9 Nov 2020

Hi @Amejia481 , verified as fixed on the latest Nightly Build 201110 using the following devices:
• Google Pixel 3a (Android 11)
• Huawei Mate 20 Lite (Android 10)
• OnePlus A3 (Android 6.0.1)

Checked 10 times each of the following websites on each of the above mentioned devices:
• https://www.cbssports.com/
• https://videojs.github.io/autoplay-tests/plain/attr/autoplay.html
• https://www.walkinto.in/tour/WyKhAFf0iXZJgF2CKzAj7

✔️ No crash encountered in 90 attempts 🥳

I'll keep an eye on this matter in the upcoming Beta | RC builds. 👀

AndiAJ on 10 Nov 2020

🎉1

Thanks @AndiAJ!

Amejia481 on 10 Nov 2020

👍1

Was this page helpful?

0 / 5 - 0 ratings