Fenix: [Bug] custom tab is always light

Created on 24 Sep 2020  ·  8Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

set night mode.
Open a volatile tab from another app.

Expected behavior

Browser bar should be dark.

Actual behavior

It's light:
Screenshot_20200923-205143_Firefox

Device information

  • Android device: SM-J600FN/DS
  • Fenix version: 80.1.3 (Build #2015762833)
CustomTabs Themes S2 hershey 🐞 bug

All 8 comments

Custom tabs are supposed to be colored by the host app, it should not follow browser theme afiak https://developers.google.com/web/android/custom-tabs/implementation-guide

It is not always light either
Screenshot_2020-09-28-01-53-24-987_org mozilla fenix

Weird. I'm using feedly, and it shows dark tabs when on dark mode and my browser is the Samsung one:

Screenshot_20200928-154822_Samsung Internet

can you specify the host app also?

this might be fixed in a newer version. Let's QA this bug in Nightly and close if we can no longer repro

can you specify the host app also?

Feedly

I had tested this on the latest Nightly 200929 05:08 (Build #2015766697) GV 83.0a1 from 9/29 with Motorola Moto G6 (Android 8), Nexus 5 (Android 6.0.1), Samsung Galaxy Tab S3 (Android 8) on several pages and the custom tab is always light, even when the app theme is set to "Dark" or "Follow device theme" and the device is set to Night mode.

Please note that the custom tab main menu, the Share and Tracking Protection pop-ups are all in Dark mode, only the custom tab bar remains light.

20200929_120639

I will remove the qa:needed label for now.

Please note that the custom tab main menu, the Share and Tracking Protection pop-ups are all in Dark mode, only the custom tab bar remains light.

Related : #10813

Was this page helpful?
0 / 5 - 0 ratings