Fenix: [Bug] Tab tray handle has wrong dimensions

Created on 19 Sep 2020  ·  3Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

  1. Open the tab tray

Expected behavior

The dimensions of the handle should be small to indicate a draggable object.

Actual behavior

The dimensions are very large, looks like a visual glitch.

tab-tray-handle-wrong

Device information

  • Android device: Sony Xperia Z2, Android 6.0.1
  • Fenix version: Nightly 200919 06:03 (Build #2015764785)
    AC: 60.0.20200917190518, a1a5c582c
    GV: 82.0a1-20200912220312
    AS: 61.0.13
Tabs S2 engverified 🐞 bug

Most helpful comment

As far as I can see, this commit https://github.com/mozilla-mobile/fenix/commit/b5635763357578967f3c486dca679739fcf503cb changed the

private const val NORMAL_HANDLE_HEIGHT = 3

(https://github.com/mozilla-mobile/fenix/commit/b5635763357578967f3c486dca679739fcf503cb#diff-e2de4b768816f0d0beea898195bce335L583)

to

<dimen name="tab_tray_normal_handle_height">11dp</dimen>

(https://github.com/mozilla-mobile/fenix/commit/b5635763357578967f3c486dca679739fcf503cb#diff-e4590692aa6da9dc0da05cbe72efa571R175).

All 3 comments

As far as I can see, this commit https://github.com/mozilla-mobile/fenix/commit/b5635763357578967f3c486dca679739fcf503cb changed the

private const val NORMAL_HANDLE_HEIGHT = 3

(https://github.com/mozilla-mobile/fenix/commit/b5635763357578967f3c486dca679739fcf503cb#diff-e2de4b768816f0d0beea898195bce335L583)

to

<dimen name="tab_tray_normal_handle_height">11dp</dimen>

(https://github.com/mozilla-mobile/fenix/commit/b5635763357578967f3c486dca679739fcf503cb#diff-e4590692aa6da9dc0da05cbe72efa571R175).

Reproducible on Nightly 9/21 with Samsung Galaxy Note10 (Android 10) and Pixel 3 (Android 11).

Verified as fixed on Nightly 200923 06:02 GV 82.0a1 from 9/23 with Samsung Galaxy Tab S3 (Android 8).

Was this page helpful?
0 / 5 - 0 ratings