Fenix: java.lang.IllegalThreadStateException at mozilla.components.feature.downloads.DownloadMiddleware$restoreDownloads$1$invokeSuspend$$inlined$collect$1.emit(Collect.kt:4)

[SinTan1729]

Steps to reproduce

Just launch firefox.

Expected behavior

Should work smoothly.

Actual behavior

Crashes everytime.

Device information

• Android device: Redmi K20 (Android 10)
• Fenix version: 200830 06:01

[hwinnemoe]

Can you still access the Settings? Then sharing the crash report via _Settings_, _About Firefox Nightly_, _Crashes_ and pressing _Share_ would be helpful here.

[SinTan1729]

No. I can't even open the app. Here's a screen record for context.

[hwinnemoe]

Do you have Fenix as your default browser? Try setting another browser as your default browser.

[SinTan1729]

No defaults have been set.

[hwinnemoe]

Ok, thanks :) Please use https://github.com/mozilla-mobile/fenix/wiki/Logging-Crash-Information#using-adb-logcat-to-get-crash-information to create a log for your crash, zip it up and attach it here. Also make sure to use adb logcat -c before reproducing the crash to clear anything else in the log. This will help the developers to find the cause for your crash.

[SinTan1729]

Here's the logcat.

[hwinnemoe]

https://crash-stats.mozilla.org/report/index/bp-aa3efb20-b3d5-4684-99ea-5b6a50200830

java.lang.IllegalThreadStateException: Expected `store` thread, but running on thread `DefaultDispatcher-worker-15`. Leaked MiddlewareContext?

java.lang.IllegalThreadStateException
    at mozilla.components.lib.state.internal.StoreThreadFactory.assertOnThread(StoreThreadFactory.kt:7)
    at mozilla.components.lib.state.internal.ReducerChainBuilder$build$threadCheck$1.invoke(ReducerChainBuilder.kt:3)
    at mozilla.components.lib.state.internal.ReducerChainBuilder$build$$inlined$forEach$lambda$1.invoke(ReducerChainBuilder.kt:3)
    at mozilla.components.lib.state.internal.ReducerChainBuilder$build$context$1.dispatch(ReducerChainBuilder.kt:1)
    at mozilla.components.feature.downloads.DownloadMiddleware$restoreDownloads$1$invokeSuspend$$inlined$collect$1.emit(Collect.kt:4)
    at mozilla.components.feature.downloads.DownloadStorage$getDownloads$$inlined$map$1$2.emit(Collect.kt:6)
    at kotlinx.coroutines.flow.internal.SafeCollectorKt$emitFun$1.invoke(SafeCollector.kt:1)
    at kotlinx.coroutines.flow.internal.SafeCollector.emit(SafeCollector.kt:24)
    at kotlinx.coroutines.flow.internal.SafeCollector.emit(SafeCollector.kt:1)
    at androidx.room.CoroutinesRoom$Companion$createFlow$1$1$1.invokeSuspend(CoroutinesRoom.kt:2)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:3)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:21)
    at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:1)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:11)

[hwinnemoe]

Thanks! Since when do you have this issue, did it also occur on e.g. yesterday's Nightly?

[kawaiiDango]

I'm having the same issue since today. It's impossible to open Firefox nightly anymore. My log also looks the same

Device: Oneplus 6, Android 10

[SinTan1729]

Thanks! Since when do you have this issue, did it also occur on e.g. yesterday's Nightly?

No. It started happening after today's update.

[hwinnemoe]

cc @Amejia481 https://github.com/mozilla-mobile/fenix/commit/c63fd3f9ac2fd511cc4b7f791353d6ff4d412fcf and https://github.com/mozilla-mobile/android-components/pull/8197/files#diff-78ef6898bdea79d57a0d51a5c39104e4R98 - those commits might be the reason for these crashes

[Amejia481]

Thanks for the report, I'm taking a look. The issue should be only reproducible in nightly as the functionality is behind a feature flag. https://github.com/mozilla-mobile/fenix/blob/aae8236478d41df2adb0c23e662e2c35dedd90f5/app/src/main/java/org/mozilla/fenix/FenixApplication.kt#L167

[B0pol]

Does it also crashes in the background? I mean when you are not even using the browser?

[kawaiiDango]

Yes

[B0pol]

OK then I think I have the same bug. You can stop crashes in the background via settings -> apps -> firefox nightly and force stop, and don't open it until it's fixed

[crisalis2]

This happens to me too, and I think it's the same as #14505

[Amejia481]

This issue will be addressed after pr lands https://github.com/mozilla-mobile/android-components/pull/8293

[Amejia481]

STR

1. Open Fenix download a file.
2. Kill Fenix (Using the tasks manager).
3. Reopen Fenix.

[Amejia481]

The issue should be fixed on master, and it will be fixed in the next update.

[LittleAngelwings]

The issues seem to be fixed. The latest update don't crashes any more.

[JamesGreeners]

So there is already an update for it?

[AndiAJ]

Hi, verified as fixed on the latest Nightly Build 200831 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 10)
• OnePlus A3 (Android 6.0.1)

► Video