Fenix: [Bug] PBM notification icon is invisible

Created on 29 Aug 2020  ·  7Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

Open a private tab

Expected behavior

You can see the PBM icon in the notification

Actual behavion

You can't
Screenshot_20200829-214723_Firefox Nightly

Device information

  • Android device: Samsung Galaxy A50
  • Fenix version: Nightly 200829 06:05 (Build #2015760755)
    AC: 57.0.20200827190112, 91f7bcbca
    GV: 82.0a1-20200827093043
    AS: 61.0.13
Notifications PrivateBrowsing S2 engverified triage 🐞 bug

All 7 comments

I think this may be related to #13228

So I bisected this and it's a regression of https://github.com/mozilla-mobile/fenix/pull/13481.

R.drawable.ic_pbm_notification was removed and replaced by R.drawable.ic_private_browsing. The problem is the fillColor of the drawable: it's used to be @android:color/white, the now used ressource has ?attr/primaryText as fillColor. Changing this to @android:color/white fixes the issue but since it's also used in other places it's not the solution. The easiest way would be to restore R.drawable.ic_pbm_notification but maybe there is a more elegant solution since the fillColor is the only difference between these two drawables. @NotWoods?

This is also reproducible on Nightly 200831 with Pixel 2 (Android 9).

Android should process non-white fills. I think the issue is that it's not loading any color from the attribute.

This is also reproducible in the latest beta update.

Verified as fixed on Nightly 9/11 and 81.1.1-beta.3 with Samsung Galaxy Note 10 (Android 10) and Google Pixel 3 (Android 11).

Was this page helpful?
0 / 5 - 0 ratings