Fenix: [Bug] In edit bookmarks, the x button dissapears after pressing backspace

Created on 12 Aug 2020  ·  7Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

Save a bookmark and then edit it
click in the Name section or the URL, press backspace on the keyboard

Expected behavior

The x icon does not disappear

Actual behavior

The x icon disappears but it still works if you click in that area

Device information

  • Android device: Asus Zenfone
  • Fenix version: Fenix Nightly
engverified 🐞 bug

All 7 comments

I see the same issue on my own phone. I have a Google Pixel 3.

I will open a pull request for the fix.

Assigning you @darren-finch :)

Assigning you @darren-finch :)

Thank you! This is my first contribution to open source, so it may take some time. Specifically I can't figure out how to run the app. It's giving me this error. I read through the README and made sure I was building the debug variant, but it won't launch the initial activity.

error

Ah yes that is annoying. You'll want to add a new configuration that starts HomeActivity.

Screen Shot 2020-08-13 at 10 39 03 AM

If you have anymore questions you can ask them here, but I'm an intern thats leaving soon so I may not be able to reply as much. Our element chat room is also a good place to ask for help (https://chat.mozilla.org/#/room/#fenix:mozilla.org)

Also sometimes I have to open the Edit configurations dialog and close it otherwise Android Studio refuses to run my HomeActivity configuration 🤷

Thanks for your help, it worked!

Verified as fixed on the latest Nightly build 8/19 with Google Pixel 4 XL (11).

Was this page helpful?
0 / 5 - 0 ratings