Fenix: [Bug] You can add a website to homescreen with a whitespace name

Created on 29 Jul 2020  ·  7Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

On any page click add to homescreen using three dot menu
Remove the default name and just add a single space to the feild

Expected behavior

Add button is disabled; it does not allow to save an empty name

Actual behavior

Allows to create the shortcut (name shows up as web site)

Device information

  • Android device: Asus Zenfone
  • Fenix version: Fenix Nightly
PWA engverified good first issue 🐞 bug

Most helpful comment

Hello, @data-sync-user @NotWoods I would like to try and work on this.

All 7 comments

Validate the string so it's not whitespace only.

Hello, @data-sync-user @NotWoods I would like to try and work on this.

Should I close this, seems to be working as intended.

Please leave the issue open as we prefer to have QA double check everything is working :)

@NotWoods perhaps you can add qa-needed label 😅

@liuche see above ^

Hi, verified as fixed on the latest Nightly Build 200921 using the following devices:
• Google Pixel 3a (Android 11)
• Huawei Mate 20 Lite (Android 10)
• OnePlus A3 (Android 6.0.1)

Was this page helpful?
0 / 5 - 0 ratings