Fenix: FNX2-15528 ⁃ [a11y] Difficult to see which tab is current in tab history

Created on 24 Jul 2020  ·  7Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

Long press back button to open tab history

Expected behavior

It's clear which tab in tab history you are on, either by inverting the colors for that item or by some other way of highlighting

Actual behavior

It's not very clear and it's only indicated by bold text which and be hard to see for a lot of people

Device information

  • Android device: Asus Zenfone
  • Fenix version: Nightly 200723 06:01 (Build #22050611)
    AC: 52.0.20200722023149, 5c2458cb8
    GV: 80.0a1-20200721094241
    AS: 61.0.10
History engverified

Most helpful comment

@s-ankur @eliserichards Let’s use the identical highlight colour value that we use in the Tab Tray for currently selected tab.

Tab Tray for comparison:

By doing this, we no longer need to bold the text.

All 7 comments

Current design (from https://github.com/mozilla-mobile/fenix/pull/12519):

@brampitoyo FYI for design input here :)

Screenshot_20200727-225917_Firefox_Nightly
Dark mode is slightly more difficult to distinguish than light mode

@s-ankur @eliserichards Let’s use the identical highlight colour value that we use in the Tab Tray for currently selected tab.

Tab Tray for comparison:

By doing this, we no longer need to bold the text.

@brampitoyo Does this mean we use the same style in normal and private mode for the tab history sheet? Similar to how the tab tray doesn't have a separate private mode style?

@person808 No – and sorry I didn’t clarify this.

We do want a separate style for private mode history stack. It should use the same background colour as the modal bottom sheet used for menu surfaces, ETP Panel, Site Information Panel – and the same background colour as in-app pages like Bookmarks.

The highlight colour value for the private theme will be the same as the one used on dark theme.

Verified as fixed on Nightly 200803 (Build #22161809) GV 81.0a1 from 8/3 with Motorola Moto G6 (Android 8) and Pixel 2 (Android 9).

Verified as fixed on 80.0.0-beta6 on several devices.

Was this page helpful?
0 / 5 - 0 ratings