Fenix: [Bug] The dialog for delete the last tab in a collection, contains the "collection" word twice when this is called "Collection x"

Created on 7 Jul 2020  ·  4Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

  1. Launch Firefox;
  2. Save one page in a collection with the custom name: "Collection x";
  3. Delete the page from the previous step, by tapping the "x" button;
  4. Observe the dialog's question;

    1. Expected behavior

      Delete Collection x?

    2. Actual behavior

      Delete collection Collection x?

    3. Screenshot

      ScreenshotUNITO-UNDERSCORE!20200707-111628!

Notes

When deleting the collection from the three-dot menu, the dialog's question is: "Are you sure you want to delete Collection 1?", so there is no duplicated "collection" word.

Device information

  • Android device: Pixel 2 (Android 9)
  • Fenix version: Nightly 200707 GV 80, from 7/7
Collections S2 triage 🐞 bug

All 4 comments

What if the collection name is not collection X? In that case removing the word collection won't create confusion? ? ?

What Firefox team can do is to set the collection name in bold letter to distinguish from the word collection

What if the collection name is not collection X? In that case removing the word collection won't create confusion? ? ?

As mentioned in the description's notes, this is already the case for when deleting the collection from the three-dot menu.

Correct copy should be:

Delete %1$s?

Deleting this tab will delete the entire collection. You can create new collections at any time.

CANCEL | DELETE

Hi! This issue is verified as fixed on Nightly 200805 GV 81.0a1 from 8/5 with Motorola Moto G6 (Android 8).
I filed a new related issue: https://github.com/mozilla-mobile/fenix/issues/13305.

Was this page helpful?
0 / 5 - 0 ratings