Fenix: [Bug] inconsistent string color
Steps to reproduce
In collection menu the delete collection item is red in color whereas in other sub menu the color is black...please make it consistent...i.e. make it red for items string such as "Remove" , "close all tabs" etc....or better why not also add a red trash icon...not big but small one...
Expected behavior
Strings in submenu for delete, close all tabs, remove etc should show in red color
Actual behavior
Shows in black color...the deletion should be easy to distinguish ...
Device information
- Android device: ? Rog phone 2 A10
- Fenix version: ? Latest nightly
UNITO-UNDERSCORE!20200630-160410!
UNITO-UNDERSCORE!20200630-160437!
UNITO-UNDERSCORE!20200630-160500!
sheikh-azharuddin
All 7 comments
This looks to me like a legitimate design consistency issue.
mcarare
on 1 Jul 2020
@betsymi @topotropic for feedback - I think any sort of destructive behaviour should be highlighted in red. I'm not sure if closing actions are considered destructive enough to warrant red text. I think we reserve red for "delete" actions and leave the rest as regular text colour.
AmyYLee
on 5 Jul 2020
@betsymi @topotropic for feedback - I think any sort of destructive behaviour should be highlighted in red. I'm not sure if closing actions are considered destructive enough to warrant red text. I think we reserve red for "delete" actions and leave the rest as regular text colour.
Makes sense to me. Do we have that documented somewhere in case it comes up again?
betsymi
on 6 Jul 2020
It would help eng to have a list of where we should or should not change this in the app.
ekager
on 10 Jul 2020
Where to have
Top site item - Remove
3 dot menu- Quit( quit browser)
Where not to have
Tab tray - close all tabs
Just a suggestion 😊
sheikh-azharuddin
on 10 Jul 2020
It would help eng to have a list of where we should or should not change this in the app.
Assigned to @betsymi
AmyYLee
on 14 Jul 2020
It would help eng to have a list of where we should or should not change this in the app.
@ekager - Basically any string with "delete" as a destruction action is marked in red. It appears we are already following this rule. Marking this as won't fix.
AmyYLee
on 14 Jul 2020
Related issues
csadilek
·
3Comments
abodea
·
3Comments
clitetailor
·
3Comments
lindongbin
·
3Comments
thelazyoxymoron
·
3Comments
Most helpful comment
@betsymi @topotropic for feedback - I think any sort of destructive behaviour should be highlighted in red. I'm not sure if closing actions are considered destructive enough to warrant red text. I think we reserve red for "delete" actions and leave the rest as regular text colour.