Fenix: FNX2-12991 ⁃ [Design] Follow ux mock on Settings --> Account screen

Created on 29 Jun 2020  ·  7Comments  ·  Source: mozilla-mobile/fenix

Breakdown from issue #7065

account

Settings engverified 🐞 bug

All 7 comments

I'm working on this.

@hakkikaancaliskan Thanks heaps for checking on this small detail! The sync icon is meant to be 24x24, just like all other icons we use on Fenix.

Asset: https://share.getcloudapp.com/ApuAXXjz

@hakkikaancaliskan Thanks heaps for checking on this small detail! The sync icon is meant to be 24x24, just like all other icons we use on Fenix.

Asset: https://share.getcloudapp.com/ApuAXXjz

Ohh, @NotWoods said photon icon is okey so i've already opened pr with photon icon. Do I need to update it?
https://github.com/mozilla-mobile/android-components/pull/7574

@hakkikaancaliskan We can use the photon icon that was merged for now.

@brampitoyo The asset you provided has a 5px margin while photon icons just has 2px margin, which better aligns with our other icons. Is the photon icons version OK to keep?

@NotWoods I didn’t know that our Photon icons have a different margin.

As strange as this may sound, the icon we have in our library has a 5px margin! But it sounds like the Photon version is more correct. Let’s use that instead.

@Mugurell this one landed, so it requires qa needed tag

Hi, verified as fixed on the latest Nightly Build 200716 from 7/16 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Screenshots
rsz_screenshot_20200716-121136

Was this page helpful?
0 / 5 - 0 ratings