Fenix: FNX2-12993 ⁃ [Design] Follow ux mock on Settings --> Accessibility screen

Created on 29 Jun 2020  Ā·  9Comments  Ā·  Source: mozilla-mobile/fenix

Breakdown from issue #7065

resim

Settings engverified šŸž bug

Most helpful comment

@hakkikaancaliskan The screenshot you provided on https://github.com/mozilla-mobile/fenix/pull/12478#issue-447800156 was already correct in terms of font family and margin between list items, but I totally forgot about the 72dp keyline gap. This was totally my mistake – sorry!

The correct spec is as follows (you can replace comment 0 with this spec if you like):

Screen Shot 2020-07-13 at 3 13 51 PM

You’ll observe that all the list items and elements (sliders, preview text box) on this page now follows the same 72dp keyline gap, as the rest of Settings.

Full credit to @cadeyrn for pointing out this inconsistency!

All 9 comments

I'm working on this.

@hakkikaancaliskan In the third image 'Zoom on all websites' should be aligned with 'Automatic Font sizing' 'Font size' position.

The mockup image seems to not match with the issue you have linked. Hope you're aware of this.

@brampitoyo what do you think about this?

@hakkikaancaliskan I’d love to see a screenshot of this screen? I’ll see it first thing tomorrow, and will provide a feedback.

@brampitoyo
resimresim

To mockup image seems to not match with the issue you have linked. Hope you're aware of this.

Look to the comment of @brampitoyo on that issue. That's the latest.

@hakkikaancaliskan The only two tweaks I would make to this page:

  • Change all the font family value from Metropolis to our default font (Inter/Roboto).
  • Make sure that the margin between ā€œFont sizeā€ and ā€œMake text on websites larger or smallerā€, matches the margin between other label heading and label text. At the moment, the margin is larger than it’s supposed to.

@hakkikaancaliskan The screenshot you provided on https://github.com/mozilla-mobile/fenix/pull/12478#issue-447800156 was already correct in terms of font family and margin between list items, but I totally forgot about the 72dp keyline gap. This was totally my mistake – sorry!

The correct spec is as follows (you can replace comment 0 with this spec if you like):

Screen Shot 2020-07-13 at 3 13 51 PM

You’ll observe that all the list items and elements (sliders, preview text box) on this page now follows the same 72dp keyline gap, as the rest of Settings.

Full credit to @cadeyrn for pointing out this inconsistency!

Verified as fixed on the latest Nightly from 7/20 with Google Pixel 4 XL (Android 11).

Was this page helpful?
0 / 5 - 0 ratings