Fenix: [Bug] error page button outline

[532910]

5.2.0

[hakkikaancaliskan]

What's your android version?
No problem on nightly.

[532910]

LineageOS 16 / Android 9

The same issue on nightly!

[hakkikaancaliskan]

This outline shown on all error screens and just when you tap the reload button.

[532910]

Yep, and when reload takes long time you'll see it all this time.

[hakkikaancaliskan]

Yep, and when reload takes long time you'll see it all this time.

That long time normal because retrying to connect to server and waits for timeout.

[532910]

Any time is normal, but the outline is not. It must not be shown at all.

[mcarare]

In this type of pages it is custom to keep a button outline (focus rectangle) as a way to help the user know that the button click was registered and the action the button triggers is ongoing, and prevent him from repeatedly clicking the button. IMO from this should be left alone, but I'm leaving the decision to UX.

[532910]

There are a lot of other ways to show the user the response, besides of ugly outline.

[AmyYLee]

I agree there shouldn't be a white outline here. Since we already have the loading bar providing feedback to the user that something is happening, I don't think it's necessary to highlight the button. @brampitoyo Do you have an opinion?

[brampitoyo]

@mcarare Having a 1px outline to acknowledge focus is ok (Chrome also does this. For maximum compatibility, we can even make this colour controlled by the system.

But we should definitely make this outline match our button height (36dp) and border radius value (4dp). Can we do that?

So it would look like this:

Just one thing to note: when the theme is set to dark, the white outline has good contrast. But when the theme is light, the black outline doesn’t. There’s nothing I can do there.

[532910]

Chrome is not a role model, but I completely agree with Bram, the main problem with current outline that it's ugly. Making it shaped solves this issue.