Fenix: [Bug] Hide save tabs to collection when there is no tab

[sheikh-azharuddin]

Steps to reproduce

When no tabs is open the home screen still shows save tabs to collection. Ideally this should show when there is atleast one tab open

Expected behavior

Save tabs to collection should not show when there is no tab opened

Actual behavior

It is showing save tabs to collection

Device information

• Android device: ? A10
• Fenix version: ? Latest nightly

[sblatz]

Agreed that this is a bit weird. Here's the current view:

[AmyYLee]

@sblatz I agree. In the previous version there was no save tabs button. @topotropic to confirm removing the button.

[vesta0]

We just added the bottom and we should add an exception to hide it when there are no tabs open.

[sheikh-azharuddin]

Thanks Emily 😊

[ekager]

Reopening for QA

[AndiAJ]

Hi, just checked this on the latest Nightly Build 200625 from 6/25 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

❌ The "Save tabs to collection" remains displayed having 0 open tabs after performing these steps:

1. Open a tab
2. Save it to a collection
3. Delete the tab
4. Delete the collection

► Video

@darkwing & @ekager - Please review ☺️

[sheikh-azharuddin]

Found one glitch here...sometime when opening new tab save tab to collection is visible for a short time... attaching a video....

[darkwing]

I'm unable to duplicate this issue at all, following @AndiAJ's steps.

[AndiAJ]

Hi @darkwing , it's still reproducible on the latest Nightly Build 200708 from 7/8 using a Google Pixel 3a (Android 10)

►Video

@sheikh-azharuddin's glitchy behaviour seem to be fixed by @mcarare 's PR https://github.com/mozilla-mobile/fenix/pull/12321

[mcarare]

Cn QA please update the status of this issue? If fixed, or is some inconsistencies still exist? TY!

[AndiAJ]

Hi @mcarare , yes, it's still reproducible with the STR mentioned above on the latest Nightly 200722 from 7/22 using a OnePlus A3 (Android 6.0.1)

► Video

[abodea]

I was able to reproduce this issue on the latest Beta 8.0.0 - beta.1.

[ekager]

Let's pull the still reproducible issue to https://github.com/mozilla-mobile/fenix/issues/13080 👍