Fenix: FNX2-13646 ⁃ [Bug] Close last tab doesn't close tab tray

Created on 23 Jun 2020 · 12Comments · Source: mozilla-mobile/fenix

Steps to reproduce

Open a page
Close it, you now have 0 tab
1. Expected behavior
  
  The tab drawer is closed so that I can access collections / top sites / settings / …
2. Actual behavior
  
  Tab tray is still shown
3. Device information

Android device: 9
Fenix version: 5.2

Tabs Skittle engverified ready 🐞 bug

Source

B0pol

👍1

All 12 comments

@gabrielluong If ux team decide how it should be, i can take this issue. Needs ux feedback.

hakkikaancaliskan on 24 Jun 2020

@gabrielluong If ux team decide how it should be, i can take this issue. Needs ux feedback.

Requested. @topotropic is still away for another week I think. Thanks!

gabrielluong on 24 Jun 2020

👍1

Yes, please close the drawer when people don't have any open tabs and show new tab/home with top sites, collections.... Thanks!

topotropic on 6 Jul 2020

@gabrielluong i don't have time to work on this currently, maybe later. Other guys could work on this.

hakkikaancaliskan on 6 Jul 2020

@topotropic when you close the last tab - we should still show the undo option though? This piece could be tricky

ekager on 6 Jul 2020

👍1

The way I handled that for the tab counter menu was to provide a the sessionId as an argument to the nav action that returns to HomeFragment and have HomeFragment handle the tab closing and snackbar.

person808 on 6 Jul 2020

👍1

Nice, so I'm assuming that's what we'd want to do here as well.

ekager on 6 Jul 2020

The way I handled that for the tab counter menu was to provide a the sessionId as an argument to the nav action that returns to HomeFragment and have HomeFragment handle the tab closing and snackbar.

does this mean we close the tab tray and show the undo snackbar on home when people close their last tab?

topotropic on 7 Jul 2020

@topotropic Yup. If we take the same approach as the tab counter menu then thats what it'll look like.

person808 on 8 Jul 2020

What should happen in the case where a user has:

1 normal tab
2 private tabs

Closes last normal tab.... should it dismiss (same goes for the inverse)? @topotropic

sblatz on 13 Jul 2020

The behavior that happens by "default" with my change is:

User State:
1 normal tab
2 private tabs

Then...
Close my normal tab

Then...
Now Fenix shows private home screen (with tray dismissed).

Which actually seems pretty reasonable to me?

sblatz on 13 Jul 2020

Verified as fixed on Nightly 7/24 with Samsung Galaxy Note 10(Android 10) and LG G7 FIT (Android 8).
Scenarios covered: normal browsing, private browsing, closing private tab from the notification.