Fenix: FNX2-16295 ⁃ [Bug] Menu has different width in english

Created on 29 May 2020  ·  3Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

  1. Look at the menu when app is set to english
  2. Switch language to german
  3. Check the menu again

Expected behavior

Menu should be 280dp no matter the language

Actual behavior

Menu has different width depending on language

🐞 bug

Most helpful comment

Menu should be 280dp no matter the language

A dynamic width of the menu was intentionally introduced in #7157.

All 3 comments

Menu should be 280dp no matter the language

A dynamic width of the menu was intentionally introduced in #7157.

Thank you @cadeyrn !

Indeed, #7157 added the possibility for the menus to grow if they need the space.
There is also #1871 which asks for the menus to be be able to shrink when there would be too much blank space, something that I was planning to work on based on bram's feedback from https://github.com/mozilla-mobile/fenix/issues/10541#issuecomment-635147257 .

That's great, wasn't aware of it. Thanks for pointing it out @cadeyrn!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Chris01277 picture Chris01277  ·  3Comments

csadilek picture csadilek  ·  3Comments

andreicristianpetcu picture andreicristianpetcu  ·  3Comments

andreicristianpetcu picture andreicristianpetcu  ·  3Comments

softvision-miralobontiu picture softvision-miralobontiu  ·  3Comments