Fenix: FNX2-16285 ⁃ [Bug] origin information missing from push notifications

Created on 28 May 2020  ·  6Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

  1. receive a push notification

Expected behavior

Notification contains information about the origin that sent the push.

Actual behavior

Notification does not indicate which origin sent it.

GV dependant feature request: https://bugzilla.mozilla.org/show_bug.cgi?id=1642345

Top notification is from Fennec bottom from Fenix.
123

Device information

  • Android device: 10.0.0
  • Fenix version: Nightly 200527 06:01 (Build #21480608)
feature request 🌟 ac gv

Most helpful comment

@TitanNano this should be fixed in the next Fenix nightly release (probably tomorrow).

All 6 comments

@jonalmeida I believe you are most familiar with the Fenix push integration. 😬️

Thanks for filing!

Hmm.. I wonder if we can propagate the scope from the push message to the web notification and surface it as the notification "origin".

I'll file a bug for GeckoView request since the web worker that processes the notification doesn't have context on the site origin.

We've added a source field to the WebNotification class in GeckoView. This will be in GeckoView 79 unless we decide to uplift to 78.

@TitanNano this should be fixed in the next Fenix nightly release (probably tomorrow).

Yeah this is fixed now. Getting the source site name.

6833

Closing as fixed.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

softvision-miralobontiu picture softvision-miralobontiu  ·  3Comments

andreicristianpetcu picture andreicristianpetcu  ·  3Comments

Chris01277 picture Chris01277  ·  3Comments

vesta0 picture vesta0  ·  3Comments

andreicristianpetcu picture andreicristianpetcu  ·  3Comments