Fenix: [Bug] [Tabs Tray] Undo close tab puts tab at the bottom of the list, rather than in-place

[liuche]

• [ ] AC bug for investigating (unprioritized right now) https://github.com/mozilla-mobile/android-components/issues/7205

Steps to reproduce

1. In the new tabs tray, delete a tab
2. Undo deleting the tab from the snackbar

Expected behavior

Tab restores in-place where it was deleted from

Actual behavior

Nothing appears to happen, but the tab appears at the bottom of the list, which is confusing (and awkward if you have a lot of tabs)

Device information

• Android device: ?
• Fenix version: ?

[darkwing]

@boek I believe we discovered we can't put the item back in place due to AC.

[liuche]

Here's the AC bug for investigating this: https://github.com/mozilla-mobile/android-components/issues/7205

[softvision-miralobontiu]

Hi all,
On the latest Beta 5.2.0-beta.2, on Samsung Galaxy Tab S6 (Android 9), after closing tab - Undo, the tab is placed at the top of the list.

[ekager]

Looks like the new AC bug for this is https://github.com/mozilla-mobile/android-components/issues/3265

[madb1lly]

Hi all,

Maybe the OP needs to be edited to clarify that due to the new tab list layout the old bottom is now the new top.

Cheers 🙂

[smithi7]

This is yet another issue that reaĺly boils down to not being able to reorder tabs.

Once we can (again) reorder our tabs, undo after deletion putting a restored tab in the wrong place will be merely a brief inconvenience.

I find it hard to believe that a simple hold-and-drag reordering of tabs (or bookmarks, for that matter) is so hard to do when FF did it for all of those years.

I run with up to 100 tabs, for different projects and interests, and so depend on order to readily find what I'm looking for. Accidentally deleted tabs - too easy, with now no hope of recovery in order - means having to delete all then rebuild tabs from collection/s, which is frustratingly time-consuming.

[dglttr]

Seems like the AC bug is fixed: https://github.com/mozilla-mobile/android-components/issues/3265.

[JeromeDeBretagne]

Issue confirmed as still present in:

• Firefox Beta 85 (85.0.0-beta.4) with AC 70.0.5
• Firefox Nightly 210101 with AC 71.0.202101011143133, f31f6d12e

so the above fix in AC is not enough in itself :disappointed:.

@ekager Could this issue be prioritized in a coming sprint :pray: as it leads to a poor experience for users with many tabs?

Hopefully, it should be much smaller than the bigger changes required to Allow users to manually re-order tabs which many of us are eagerly waiting for :heart_eyes:. Thanks.

[Djfe]

the thing is: the experience got worse 😅
When the oldest tab was still at the bottom and you restored a tab, it would jump to the restored tab for you.

Since the oldest tab is now at the top (one of the last release updates), you have to scroll manually, which takes over a minute for a thousand tabs (I think)

It places the tab at the bottom of the list without telling you where the tab is.
It feels like it didn't got restored at all.