Fenix: FNX2-16223 ⁃ Fennec migration: Tapping the device back button returns to onboarding migration screen when the "Update complete" is used

[ebalazs-sv]

Preconditions:

Have Fennec Beta installed.

Steps to reproduce

1. Replace Fennec Beta with Fenix Beta;
2. Tap the "Update complete" notification;
3. Tap the device back button;
4. Observe the behavior.
   
   
   
   1. Expected behavior
      
      The app is dismissed.
   
   
   2. Actual behavior
      
      The migration onboarding screen is displayed.
   
   
   3. Notes:
      
      Video
      
      This is reproducible only when the "Update complete" notification is tapped.
      
      When the migration onboarding screen is dismissed by tapping the "Start Firefox" button, this is not reproducible.
      
      Not reproducible on Nightly migration build 9, 02/14 and Beta migration build 1, 02/24
   
   
   4. Device information
   
   

• Android device: Google Pixel 2 (Android 9); Motorola Nexus 6 (Android 7.1.1);
• Fenix version: Beta migration build 2, 02/27; Nightly migration build 3/3;

[ebalazs-sv]

This is reproducible on Beta Migration Build 3, 3/4 with Huawei P9 Lite (Android 7), OnePlus 5T (Android 9).

[ebalazs-sv]

This is reproducible on Beta Migration build 4.0.0-beta.2, 3/10 with Huawei P9 Lite (Android 7), Pixel 2 (Android 9).

[LaurentiuApahideanSV]

The issue still occurs on Beta Migration Build (75.0.0-beta.1) 3/24 with OnePlus 6T (Android 9).

[ebalazs-sv]

This is reproducible on Beta Migration 75.0.0-beta.3, from 4/1, with Pixel 2 (Android 9) and Huawei P9 Lite (Android 7).

[softvision-miralobontiu]

Also reproducible on Migration Beta build 75.0.0-beta 4.
Tested with OnePlus 5T (Android 9).

[Diana-Rus]

Hi, still reproducible with Samsung Galaxy S9 (Android 8) on Beta Migration build 75.0.0-beta 5.

[jonalmeida]

I have some ideas on how to fix this, so I can take a look into it next sprint.

[ebalazs-sv]

This issue is reproducible on Beta Migration build 76.0.0-beta.1, from 5/1, with Nexus 5 (Android 6.0.1); Motorola Moto G6 (Android 8).

[ebalazs-sv]

This issue is reproducible on Beta Migration Build 76.0.0-beta2, from 5/14 with Motorola Moto G6 (Android 8).

[jonalmeida]

@ebalazs-sv would it be possible to test this out on a nightly migration build? Since we've tried to fix this bug before, it would be great to know if the fix works fine before we cut a major release build.

[ebalazs-sv]

@jonalmeida I had tested this on the latest Nightly Migration Build 2015742417 GV 78 with Nexus 5 (Android 6.0.1), Motorola Moto G6 (Android 8), Pixel 2 (Android 9) and the issue is not reproducible.

Tapping the device back button after the "Update complete" notification is used, will exit the app. When reopening Fenix, the onboarding tour is displayed.

I will remove the qa:needed. Thanks!

[ebalazs-sv]

This issue is reproducible on Beta Migration Build 5.1.0-beta.3 with Motorola Moto G6 (Android 8).

[jonalmeida]

@liuche it seems the fix for this didn't make it into the beta build, but it landed 8 days ago. I can't find the commit on the 5.1.0 release. 🤔

[liuche]

The 5.1 build was cut a couple of weeks ago, so this will go into 5.2. If we wanted this in 5.1 we would have needed to get an uplift flagged for it.

[jonalmeida]

Could we have this re-tested on the 5.2 release?

[ebalazs-sv]

Verified as fixed on Release Migration 5.2.0 (Build #2015747017), from 6/18 with Motorola Moto G6 (Android 8).

Tapping the device back button after the "Update complete" notification is used, will exit the app. When reopening Fenix, the onboarding tour is displayed.

I will remove the qa:needed label.

[jonalmeida]

Thanks @ebalazs-sv !