Fenix: FNX2-16191 ⁃ [Bug] Open links in apps does not open links in apps

[SeburoSUMO]

Steps to reproduce

With "Open links in apps" toggled to on

• Search for Youtube in Google
• Select the link for YouTube

Expected behavior

YouTube App opens

Actual behavior

YouTube page opens

Device information

• Android device: Moto E5, Android 8
• Fenix version: Nightly 200519 06:00 (Build #21400606)

[ImranR98]

This is also a problem for my banking app (CIBC in Canada). When someone sends me money, the link in my email takes me to a webpage with an 'open in app' button. Clicking this button should open the bank app, but doesn't. Works fine in the regular Firefox app.

[ghost]

Duplicate of #9923 but the issue has been marked as closed and links still don't redirect to their respective apps for me as well on Nightly 200519 18:01 (Build #2015741267). #10436 is also still reproducible for me.

Edit: Still doesn't work on Nightly 200527 06:01and the issue #9923 has been closed and marked as fixed.

[agreenbhm]

For me, this is also happening with the official Wikipedia app and the Reddit app "Relay for Reddit". If I choose the option "open in app" when already on the page it will open with the correct app at that point. Also, Amazon does not open in the app, but also does not show "open in app" in the menu, so I can't manually switch it either.

[ghost]

@vesta0 @ekager I also reported this #10436 bug it was closed and marked as duplicate in favour of #9923. Is the bug that I reported defferent than this or am I not understand this clearly?

[kbrosnan]

In my investigation of #11353 this looks to be an issue with Google search links. I suspect that whatever they do for redirection breaks the open in app feature.

Steps to reproduce

• Enable open in app in the settings
• Search for maangchi youtube on Firefox (or whatever Youtube content you want) using Google
• Click on Google search link to a Youtube video
• Tab opens to play video

Expected behavior

Content opens in Youtube app

Actual behavior

Content opens in Firefox tab

Workaround

• Request desktop site allows the Google page to open in app
• DuckDuckGo mobile search allows open in app to work

[rocketsroger]

This is also a problem for my banking app (CIBC in Canada). When someone sends me money, the link in my email takes me to a webpage with an 'open in app' button. Clicking this button should open the bank app, but doesn't. Works fine in the regular Firefox app.

@ImranR98 your issue seems like its different from this. We recently had a new fix from GeckoView and it was meant to fix issues related to yours. Can you please check with the latest nightly to see if your issue has been resolved? If not we might need to open an issue to track it. Thanks

[rocketsroger]

Confirmed that the YouTube issue from google search is due to how google redirect its search before loading the YouTube URL. Currently app links does not automatically open links in an external app if the link was loaded due to a redirect. This is to prevent sites from opening an external app without user's gesture. The fix is to open links in external apps even with redirect. This is a requirement discussion.

[rocketsroger]

@vesta0 Should we assume that the user wants any links to be opened in external apps even if the link is open due to a redirect?

[vesta0]

@rocketsroger yes that should be the expected behaviour for when "open in app" it toggled on.

[rocketsroger]

@rocketsroger yes that should be the expected behaviour for when "open in app" it toggled on.

Understood. I'll make the changes. Thanks,

[ghost]

I can still reproduce the issue #10436 on the latest Nightly 200627 06:01 on Motorola One Power, Android 10.

QA if you're testing this then please test the mentioned issue as well since this bug and the mentioned one are same issues.

[rocketsroger]

I can still reproduce the issue #10436 on the latest Nightly 200627 06:01 on Motorola One Power, Android 10.

QA if you're testing this then please test the mentioned issue as well since this bug and the mentioned one are same issues.

The fix was merged last night. Once A-C version is updated next week this issue should be fixed. Thanks,

[ghost]

@rocketsroger this works perfectly on all websites I have tested, on Nightly 200628 06:01 but I have found some websites where it doesn't redirect to the Play Store

1. https://www.androidpolice.com/2020/06/27/the-best-free-and-open-source-alternatives-to-gmail-on-android/

On the above site there're 2 links where they redirect to FairMail and K-9 Mail. Click on them and see it doesn't redirect to the Play Store app but instead opens the Play Store website. On Chrome browser it redirects to the Play Store on clicking those links.

1. https://www.apkmirror.com/apk/mozilla/firefox-preview-nightly-for-developers/firefox-preview-nightly-for-developers-nightly-200505-0600-release/

Here click on the Play Store icon and see it doesn't redirect to the Play Store and instead redirects to the Play Store website. On Chrome browser it opens the Play Store app.

[rocketsroger]

Fenix nightly with A-C 48.0.20200628130058 this should be fixed

[rocketsroger]

@rocketsroger this works perfectly on all websites I have tested, on Nightly 200628 06:01 but I have found some websites where it doesn't redirect to the Play Store

Do you mind opening a new issue? I'll have to investigate, since play store redirect is different than this issue. Thanks!

[ghost]

@rocketsroger this works perfectly on all websites I have tested, on Nightly 200628 06:01 but I have found some websites where it doesn't redirect to the Play Store

Do you mind opening a new issue? I'll have to investigate, since play store redirect is different than this issue. Thanks!

Yes, I'll create a new issue for it. And let you know in a moment when I have done so.

Thanks! :)

[ghost]

@rocketsroger Here's the issue for Play Store links #12092.

[rocketsroger]

@rocketsroger Here's the issue for Play Store links #12092.

Thanks!

[sv-ohorvath]

I have verified the STR from the description and the comment below, both issues are fixed on Beta 79.0.0-beta1. Closing.

I can still reproduce the issue #10436 on the latest Nightly 200627 06:01 on Motorola One Power, Android 10.
QA if you're testing this then please test the mentioned issue as well since this bug and the mentioned one are same issues.

The fix was merged last night. Once A-C version is updated next week this issue should be fixed. Thanks,

[rocketsroger]

I have made changes to prevent some bad redirect cases. Google search result directly to external apps (Facebook, Twitter, Youtube etc) will stop working. The user have to use the menu to open the page in app after it is loaded. https://github.com/mozilla-mobile/android-components/issues/7637.