Fenix: FNX2-16177 ⁃ [Bug] Crash when using voice input for Search with disabled Google App

[hwinnemoe]

Steps to reproduce

1. Deactivate voice input on Android, e.g. by disabling the Google app
2. Open Fenix Nightly
3. Tap on search area of bottom bar
4. Tap on microphone symbol (see #1216)

Expected behavior

A snackbar is displayed informing the user about missing permissions or deactivated voice input search / microphone symbol is not shown at all

Actual behavior

The app crashes. This does not change if I allow Fenix to access my microphone or not.

about:crashes shows:
_android.content.ActivityNotFoundException:
No Activity found to handle Intent
{ act=android.speech.action.RECOGNIZE_SPEECH (has extras) }_

Sidenote: I could not find my crash reports on crash-stats.mozilla.org. Also, accessing about:crashes via about:support does not show any sent crash reports.

Device information

• Android device: Sony Xperia Z2, Android 6.0.1
• Fenix version:
  Nightly 200520 06:01 (Build #2015741361)
  42.0.20200518130035, f0cb2cca9
  GV: 78.0a1-20200517094345
  AS: 0.58.2

[astarq]

Do you have the google app disabled?

[B0pol]

I can reproduce. I don't have any Google apps or services, I just have microG.

[astarq]

I have THE google app disabled, which acts as the voice recognition provider, that'll be why it crashes. The mic button shouldn't exist when that's the case, like in other apps

[hwinnemoe]

Do you have the google app disabled?

Yes, the Google App is disabled. Also, Fennec does not show me the microphone button. I have updated the issue's title and description accordingly.

[astarq]

Fennec has it right then.

[Diana-Rus]

Hi, thank you for the report I can also reproduce this with Samsung Galaxy S9 (Android 8) on Fenix Nightly 5/22. The crash is present when tapping on the mic from Adress bar but also on the mic from search widget.
10809-Crash-Logcat.txt

[yoasif]

In case you needed another log:

https://gist.github.com/yoasif/66a63d8d0d217a4b8f97e8731a52814c

I also don't have a Google App on this device (Moto G XT1031).

[Diana-Rus]

Hi, verified with Samsung Galaxy S9(Android 8) and Google Pixel 3 XL (Android 9):

Scenario 1 - Mic is not displayed in browser when Google app is disabled - PASS
Scenario 2 - Mic is displayed in search widget when Google app is disabled while widget is set before disabling the Google app - FAIL (crash present)
Scenario 3 - Mic is not displayed when Google app is disabled when the widget is added after the Google app is disabled - PASS

GIF

I'll remove the qa needed label until further notice.

Note:

• For scenario 3 when re-enabling the Google app, in order for mic to reaper in widget you need to restart the device.

[sblatz]

Hi @Diana-Rus that sounds like an existing bug with the search widget and is unrelated to the changes I made. I'll file a separate bug for that. Since the crashes with voice in search screen are fixed, I will close this :)