Fenix: [Bug][a11y] Site Permission-Touch target-Site permissions statuses need to have the touch target resized

Created on 7 Apr 2020  路  5Comments  路  Source: mozilla-mobile/fenix

Prerequisites

Have Google Accessibility Scanner installed.

Steps to reproduce

  1. Open app and navigate to "permission.site".
  2. Enable the "https" version.
  3. Tap on one of the options that generates the site permission pop up such as Location.
  4. Check the "Remember decision for this site" and tap on "allow".
  5. Tap the "Lock" icon for the site.
  6. Scan screen.

    Expected behavior

There are no suggestions to make any changes.

Actual behavior

Site permission details - Location status

  • org.mozilla.fenix.nightly:id/locationStatus
    This item's height is 28dp. Consider making the height of this touch target 48dp or larger.

Device information

  • Android device: Samsung Galaxy S9 (Android 8)
  • Fenix version: Nightly 4/7 (Build #20980610)

Note:

  • The same actual result is present for "Camera" or "Microphone" status field the height is 28 dp.
  • It needs to be taken into consideration that when one site contains multiple permissions, the space between the saved permissions the height is limited please check last screen.

Screen:
Site permission details - "Location" status
Screenshot_20200407-184516_Accessibility Scanner

Site permission details
screenshot_Firefox Nightly_2020-04-07-18_44_46-edit

SitePermissions P2 S2 a11y good first issue 馃悶 bug

Most helpful comment

@Mugurell Looks great to me!

All 5 comments

Increasing touch target will mean increasing the size of the items so the layout will change.
Asking for UX feedback if this should be done or not.

Assigning to @brampitoyo

@Mugurell If we increase it to 48dp as recommended, would you be able to post a screenshot?

It鈥檚 likely going to be fine for the layout. We just need to double-check and make sure that it doesn鈥檛 break anything or introduce awkward empty spaces.

@Mugurell If we increase it to 48dp as recommended, would you be able to post a screenshot?

It鈥檚 likely going to be fine for the layout. We just need to double-check and make sure that it doesn鈥檛 break anything or introduce awkward empty spaces.

It would indeed look better:

Current Proposed

@Mugurell Looks great to me!

Was this page helpful?
0 / 5 - 0 ratings