Fenix: [User Story] 3rd party password manager apps support

[abodea]

Notes

This is a follow up with the current situation regarding more password manager apps.
Initial bug closed now.

User Story

• As a user, I want to be able to use the password manager apps.

Dependencies

Most popular password manager apps:

• [ ] [My passwords - Password Manager](https://play.google.com/store/apps/details?id=com.er.mo.apps.mypasswords&hl=en)
• [ ] [LastPass Password Manager](https://play.google.com/store/apps/details?id=com.lastpass.lpandroid&hl=en)
• [x] [Password Safe - Secure Password Manager](https://play.google.com/store/apps/details?id=com.reneph.passwordsafe&hl=en)
• [ ] [Password Manager SafeInCloud](https://play.google.com/store/apps/details?id=com.agilebits.onepassword&hl=en)
• [x] [1Password - Password Manager and Secure Wallet](https://play.google.com/store/apps/details?id=com.safeincloud.free&hl=en)
• [x] [Avast Passwords](https://play.google.com/store/apps/details?id=com.avast.android.passwordmanager&hl=en)
• [x] [Bitwarden Password Manager](https://play.google.com/store/apps/details?id=com.x8bit.bitwarden&hl=en)
• [x] [Enpass Password Manager](https://play.google.com/store/apps/details?id=io.enpass.app&hl=en_US)
• [x] [Lockwise](https://play.google.com/store/apps/details?id=mozilla.lockbox&hl=en)
• [x] [Password Keeper (Black Berry](https://play.google.com/store/apps/details?id=com.callpod.android_apps.keeper&hl=en)

Acceptance Criteria

• [ ] Password manager app can access Fenix
• [ ] Fenix fills out logins automatically
• [ ] Fenix fills out logins automatically after the password manager app was changed
• [ ] Focus app parity

Below I will update the table once I will move forward with the testing and I will add information regarding what issues need to be fixed/investigated if it will be the case to contact the password manager apps developers.

| App | Autofill? | Bugs | Comments |
| :--: | :--: | :---------: | :--: |
| My passwords | | | |
| LastPass | | https://github.com/mozilla-mobile/fenix/issues/4205 | |
| Password Safe | N/A | - | Note that this is offline storage for accounts, I was able to copy/paste any account in Fenix, works as expected |
| SafeInCloud |❌ | https://github.com/mozilla-mobile/fenix/issues/10621 | |
| 1Password| ✅ | - | autofill can be done without problems|
| Avast Passwords | ❌ | https://github.com/mozilla-mobile/fenix/issues/10628, https://github.com/mozilla-mobile/fenix/issues/10922 | |
| Bitwarden | ✅ | - | autofill can be done without problems
| Lockwise | ✅ | https://github.com/mozilla-mobile/fenix/issues/9905, https://github.com/mozilla-mobile/fenix/issues/3511 | autofill can be done without problems |
| Enpass | ✅ | https://github.com/mozilla-mobile/fenix/issues/10640 | autofill can be done without problems
| Password Keeper (Black Berry)| ✅ | - | autofill can be done without problems

| General bugs |
| :-----------------: |
| https://github.com/mozilla-mobile/fenix/issues/9854 |

[ghost]

I use Enpass Password Manager, is there going to be support for that as well?

[cadeyrn]

Please also test with Firefox Lockwise. It's not the most popular password manager, but important for other obvious reasons. :)

[abodea]

I use Enpass Password Manager, is there going to be support for that as well?

Hi @SS1113 I will include that one as well, thank you for the recommendation!

[abodea]

Please also test with Firefox Lockwise. It's not the most popular password manager, but important for other obvious reasons. :)

Hi @cadeyrn I was going to include Lockwise too, I'm working on Lockwise too so I test that more often.

[hakkikaancaliskan]

@abodea #7742

[ghost]

Enpass password manager still doesn't work on all my 4 devices, don't know why it is still marked as working in this issue.

Relevant issue: https://github.com/mozilla-mobile/fenix/issues/10640

[abodea]

I will re-check it @SS1113 and come back with some info, I had no issues with Enpass.
Can you please tell me what build are you using? From Play Store I suppose?

[ghost]

I will re-check it @SS1113 and come back with some info, I had no issues with Enpass.
Can you please tell me what build are you using? From Play Store I suppose?

Nightly 200706 06:01 it's from the Taskcluster. The build that used to be Firefox Preview but is now Firefox Nightly.

[ghost]

Nightly 200706 06:01 it's from the Taskcluster. The build that used to be Firefox Preview but is now Firefox Nightly.

abodea, I am the reporter of this issue https://github.com/mozilla-mobile/fenix/issues/10640; Enpass Password Manager not working. Please let me know if I can provide you any more information. Thanks. :)

[ekager]

@abodea could we possibly test LastPass (and one other password manager that worked from comment 0 to compare) on the migrated release, beta, and nightly channels?

[abodea]

@abodea could we possibly test LastPass (and one other password manager that worked from comment 0 to compare) on the migrated release, beta, and nightly channels?

Hi, @ekager tomorrow I will start testing those and add the results here!

[hakkikaancaliskan]

@abodea could we possibly test LastPass (and one other password manager that worked from comment 0 to compare) on the migrated release, beta, and nightly channels?

Hi, @ekager tomorrow I will start testing those and add the results here!

Please don't forget to test #7742 too :)

[abodea]

I re-tested this for more details please check the following:

| App | Browser | Autofill?| Bugs| Comments | GV |
| :--: | :--: | :---------: | :--: | :--: | :--: |
| 1Password |Migrated RC (latest) | ✅ | - | - | 79.0.2 |
| 1Password |Latest Beta migration | ✅ | - | - | 80.0.0-beta2 |
| 1Password |Latest Debug (from master) | ✅ | - | - | 81.0a1 |
| 1Password |Brave | ✅ | - | - | N/A |
| 1Password |Chrome| ✅ | - | - | N/A |
| LastPass |Migrated RC (latest) | ❌ | - | - | 79.0.2 |
| LastPass |Latest Beta migration | ❌ | - | - | 80.0.0-beta2 |
| LastPass |Latest Debug (from master) | ❌ | - | - | 81.0a1 |
| LastPass |Brave | ✅ | - | - | N/A |
| LastPass |Chrome| ✅ | - | - | N/A |

Note that for LastPass sometimes the autofill pop up is not even displayed.
And when I was able to trigger the autofill pop up from LastPass, the same issue described here https://github.com/mozilla-mobile/fenix/issues/4205 is present in all 3 builds.

Example from latest debug build from master.

Example from Brave.

Lastpass Gif

IMO nothing changed regarding password managers and the issues that are present in the description are still reproducible.

@hakkikaancaliskan note that I tested #7742 https://github.com/mozilla-mobile/fenix/issues/7742#issuecomment-668668127 and I added a comment there. I will investigate more languages once I will have time.

[ekager]

Thanks so much @abodea !

[ghost]

Hi, @abodea I'm facing problems while using autofill using Enpass on my device but the issue description says that there's no problem with it. Is there any workaround that I can use to make it work? Or am I missing something?

The pop-up dialogue seem to be continuously appearing and disappearing just as in the issue description that you linked #10640.

[abodea]

Hi, @abodea I'm facing problems while using autofill using Enpass on my device but the issue description says that there's no problem with it. Is there any workaround that I can use to make it work? Or am I missing something?

The pop-up dialogue seem to be continuously appearing and disappearing just as in the issue description that you linked #10640.

Hi, @FrostedIce339 thank you for your comment.
If you check https://github.com/mozilla-mobile/fenix/issues/10640#issuecomment-629135567 my comment I also attached a GIF while I auto-filled with Enpass. Based on that I added the status on my bug description but I still added the bug submitted so we can keep the track of it.
I will investigate and try to auto-fill again with Enpass and get back to you.
Until then can you please let me know what device and on what build are you trying to reproduce this issue? (please attach a screenshot with about).

[abodea]

Hi, @vesta0 I re-tested the last version of LastPass for more details please check the following:

| App | Browser | Autofill?| Bugs| Comments | GV |
| :--: | :--: | :---------: | :--: | :--: | :--: |
| LastPass |Migrated RC 79.0.4 (latest) | ❌ | https://github.com/mozilla-mobile/fenix/issues/12128 | As described here the LastPass doesn't do anything, there is an error message: "Please scroll the browser window until the website address is visible, then try again." error is displayed | 79 |
| LastPass |Latest Beta migration 81.0.0-beta.1 | ❌ | https://github.com/mozilla-mobile/fenix/issues/12128 | As described here the LastPass doesn't do anything, there is an error message: "Please scroll the browser window until the website address is visible, then try again." error is displayed | 80 |
| LastPass |Latest Nightly | ✅ | - | The autofill pop-up is displayed only when tapping on the LastPass app from the notification bar (for more details please check the attachments below) | 81.0a1 |

NOTE:

• Right now the only way to make the LastPass pop-up appear in Fenix is to tap on the LastPass app from the notification bar.
  And I was able to do this only when I enabled the Legacy autofill from the LastPass app (this will add the LastPass on the notification bar and after tapping on it the autofill pop-up will be displayed in Fenix Nightly).
  

• I tested with Chrome, Brave, and many other browsers and when I tapped on the username/password field the LastPass appeared without problems.
  Below you can see that right after I tapped on the username field in Brave browser, the LastPass pop up was displayed.
  

Regarding https://github.com/mozilla-mobile/fenix/issues/4205 I couldn't reproduce the issue, I will keep investigating it, but I do have Mozilla accounts saved on my LastPass account and I was able to autofill in the latest Nightly without problems on Twitter/Fb.

[jamy015]

And I was able to do this only when I enabled the Legacy autofill from the LastPass app (this will add the LastPass on the notification bar and after tapping on it the autofill pop-up will be displayed in Fenix Nightly).

Even legacy autofill isn't working for me. The autofill pop-up just doesn't show at all after tapping the LastPass icon in the quick settings drawer.

79.0.5 (Build #2015758619)
AC: 48.0.15, 8755ac0cd
GV: 79.0.1-20200813192915
AS: 61.0.10

[vesta0]

We are working with LastPass to fix this issue. LastPass has not yet implemented support for the new autofill API but they are working on it. @abodea we should test this again in a month.

[tstackhouse]

LastPass has had support for the Android Oreo auto fill API for quite a long time. My impression was that this was something related to Fenix not properly interacting with that system level API to allow any compatible app to provide autofills...

[serovar]

1Password does not recognize anymore the websites you are in on Nightly.

[kbrosnan]

It may be as simple as Lastpass is forcing Firefox into their legacy implementation and need to add org.mozilla.firefox, org.mozilla.firefox_beta and org.mozilla.fenix to their modern autofill whitelist. We have talked with them and they are looking into it from their side. Considering there are several other password mangers that work with Firefox and we have not heard any issues from those companies/user it seems reasonable that the problem is on Lastpass to investigate.

[liuche]

Also seeing a user report from #14633 for Keepass, which isn't in this list.

[sarumont]

@kbrosnan Is there any open issue with Lastpass that we could follow / vote for / bug them about? :) Still not working for me, so it appears that they are a bit slow...

[tgsachse]

Also would like to follow this thread ^

[rugk]

Also would like to follow this thread ^

You can just click the “Subscribe” button on the right on GitHub. No need to comment… :smiley: