Fenix: [Bug] Can't Use Address Bar while Snackbar is Displayed

Created on 31 Mar 2020  ·  5Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

Scenarios
This bugs only occurs for specific snackbars, not for all. From what I've found out, the bug occurs at least for these two:

  • "URL copied to clipboard" snackbar

    • go to a website

    • tap and hold the address on the address bar

    • tap 'Copy' to copy the address

  • "Deleted «top-level domain»" snackbar

    • go to a website

    • save it as a bookmark

    • edit the saved bookmark

    • delete the bookmark

  • try to tap the address to edit it or try to tap another button on the address bar

The bug does not take effect for these snackbars:

  • "Bookmark saved! 'EDIT'" snackbar
  • "New tab opened 'SWITCH'" snackbar
  • "Tab closed 'UNDO'" snackbar
  • "Added to top sites!" snackbar

Expected behavior

After copying the address, the confirmation snackbar is displayed saying "URL copied to clipboard".
It's displayed above the address bar without overlapping it. So the address bar is fully accessible in theory. Tapping the address field is supposed to open the keyboard to edit the URL and tapping other buttons on the address bar should trigger the right action, too.

Actual behavior

The address bar is not useable while the confirmation snackbar "URL copied to clipboard" is displayed. There is no reaction to tapping anywhere on the address bar.

Device information

  • Android device: Samsung Galaxy S9+ (Android 8.0.0)
  • Fenix version: 4.2.0
Snackbar S2 🐞 bug

Most helpful comment

I was testing this, and I noticed that this snackbar appears right on top of the address bar as of version Nightly 200723 06:01 (Build #22050611). Is that a regression or was it always the case? If so, it should be changed to be consistent.

Swipe-to-switch tabs broke a lot of snackbars and some slipped through the cracks. I'll break this one out into another issue since I think I have a fix.

"Tab closed"/"Private tab closed" snackbar: appears when closing a normal/private tab by long-pressing on the tab icon and tapping on "Close tab". This snackbar also covers/overlays the toolbar (#12868).

There is a fix for this one. See the issue I edited in

All 5 comments

I can confirm that this issue is reproducible using the latest version of Firefox Preview Nightly 3/31 (Build #20910607).

Devices:
OnePlus 6T (Android 9);
Huawei MediaPad M3 lite 10 (Android 7.0)

This is happening in cases where we display the snackbar on ContentFrameLayout (which we need to do in order to display it while navigating to another fragment). I'm not sure what options we really have here other than getting rid of those types of snackbars.

As of Nightly 200722 06:08 (Build #22040614), I have discovered four more snackbars that not only obstructs the address bar while it is displayed, it also cannot be dismissed by swiping right on it:

  • "Tab sent!" snackbar: appears when sending a tab to another device (issue mentioned here).
  • "Private tab closed" snackbar: appears when closing the last private tab. Note that this only applies when you are closing the last tab (#11851).
  • "Successfully uninstalled {add-on name}" snackbar: appears when you uninstall an add-on. This snackbar also covers/overlays the toolbar, unlike others which appear above the toolbar (#9196).
  • "Tab closed"/"Private tab closed" snackbar: appears when closing a normal/private tab by long-pressing on the tab icon and tapping on "Close tab". This snackbar also covers/overlays the toolbar (#12868).

Please fix these issues. Having to wait for the snackbar to disappear before the toolbar is usable becomes really annoying after a while.

"New tab opened 'SWITCH'" snackbar

I was testing this, and I noticed that this snackbar appears _right on top_ of the address bar as of version Nightly 200723 06:01 (Build #22050611). Is that a regression or was it always the case? If so, it should be changed to be consistent.

I was testing this, and I noticed that this snackbar appears right on top of the address bar as of version Nightly 200723 06:01 (Build #22050611). Is that a regression or was it always the case? If so, it should be changed to be consistent.

Swipe-to-switch tabs broke a lot of snackbars and some slipped through the cracks. I'll break this one out into another issue since I think I have a fix.

"Tab closed"/"Private tab closed" snackbar: appears when closing a normal/private tab by long-pressing on the tab icon and tapping on "Close tab". This snackbar also covers/overlays the toolbar (#12868).

There is a fix for this one. See the issue I edited in

Was this page helpful?
0 / 5 - 0 ratings