Fenix: Edit Logins

[vesta0]

User Story

As a user, I want to be able to edit my logins, so I have control over changing them manually.

Acceptance Criteria

I can edit my logins in Logins settings

• [x] Add kebab (three dot) menu to login info toolbar with options to edit and delete
• [x] Add fragment with editable fields
  
  
  
  • disable web address editing - YES
  
  
• [x] Error states
  
  
  
  • possibly break this out into a separate piece of work?
  
  
• [x] Save enabled only when valid
  
  
  
  • Successful save routes to site info page
  
  
• [x] Cancel (X) button
  
  
  
  • where does cancel route to - login info
  
  
  • do we want a confirmation dialog - no
  
  
• [x] Feature flags

Designs

UX Mocks

SVG Icons

checkmark
drop-down arrow
warning
clear text field

[eliserichards]

@jonichan Hey Joni! Just wanted to let you know that I will be starting this issue soon and I'll reach out to you about getting some help docs on the SUMO site! 😄

[ekager]

Reopening for QA

[ebalazs-sv]

Hi!
I tested this on Fenix Nightly Build 21420606 from 5/21 with Nexus 5 (Android 6.0.1), Motorola Moto G6 (Android 8), Google Pixel 2 (Android 9) and these are the results:

| Status | Options/Settings | Notes |
| ------------- | ------------- | ------------- |
| ✔️ | Kebab ⋮ button| This button is displayed as in the UX Mocks |
| ❓ | Kebab ⋮ button menu (Edit & Delete)| Different menu style compared to the one from the sort logins section|
| ✔️ | Fragment with editable fields | The Username and Password fields are editable |
| ✔️ | Fragment with editable fields - disable web address editing | The Site is not editable |
| ❓ | Fragment with editable fields | The show/hide button is actionable on the all Password field |
| ❓ | Fragment with editable fields | The password becomes uneditable if tapped anywhere else than the end of the password |
| ❓ | Save enabled only when valid - Successful save routes to site info page | The edited login can be saved even if the username field is empty or left incomplete |
| ❓ | Error states | This is not available |
| ❓ | Cancel (X) button | This is not available |

CC @eliserichards and @AmyYLee Please review and advice the above findings.
Also the Error states and Cancel button are not implemented.

There is filed one issue related to this:
https://github.com/mozilla-mobile/fenix/issues/10725

I will remove the qa:needed until further notice. Thanks!

[eliserichards]

Moving this to "done" as the missing pieces haven't been implemented yet (#10173 and #10172)

[liuche]

Close this issue because the subsequent pieces will be in the follow-ups, that have been filed.