Fenix: [Bug] Make Home -> Search & Browser -> Search animation play nicely with top toolbar

Created on 12 Mar 2020  ยท  8Comments  ยท  Source: mozilla-mobile/fenix

Currently when a user has a top toolbar enabled, the animation looks a bit odd. We should just do a cross fade in this case instead of doing "fade_in_up.xml"

animation looks odd 2020-03-12 10_38_37

engverified motion-design ๐Ÿž bug

All 8 comments

can i work on this issue?

@ahmedmamdouh13 go for it ๐Ÿ˜„ please let me know if you run into any issues!

Thank you for the opportunity ๐Ÿ™

hey, i made a PR but I'm not familiar with TaskCluster.yml.

should i do something for the message appearing in the end of the PR?

Thank you!

Tested and verified, following the same steps as in the description, on Nightly build 200331 with Nokia 6 (Android 7.1.1), Xiaomi Mi Pad 2 (Android 5.1) and Samsung Galaxy Note 10 (Android 10).

@sblatz @ahmedmamdouh13 could you please take a look at the video and confirm that the animation for "Search or enter address" is the expected one? Thank you.

20200331_164150

@sflorean yes.

Thanks for your help on this @ahmedmamdouh13! ๐Ÿ˜„

@sblatz ohh, i mean thank you for letting me ๐Ÿ˜, i would really like to be more involved if this is okay.

Was this page helpful?
0 / 5 - 0 ratings