Fenix: [Bug] Different size icons for "Not yet available" addons

[sflorean]

Prerequisites

• On Fennec, various add-ons are installed (i.e. uBlock Origin, HTTPS Everywhere, Ghostery, etc).
• Replace Fennec with Fenix.

Steps to reproduce

1. Go to Settings - Add-ons - "Not yet supported".
2. Check the icons.

Expected behavior

The icons have the same size.

Actual behavior

The addon logo and delete icons are different in size.

Device information

• Android device: Google Pixel (Android Q)
• Fenix version: 4.0.0 - beta.1

[gabrielluong]

@brampitoyo Can you point sizes for the icons?

[brampitoyo]

@gabrielluong It’s odd that the label text is aligned right and has the wrong colour.

The spacing + dimension + colour we use on this page, should match our History and Bookmarks pages. Both pages use the same large icon (left side) and normal-size icon (right side). Although we don’t have caption underneath each label like those pages, the text sizes they use are correct.

Inspectable mockup:
https://share.goabstract.com/56dfcf1d-727e-4fc3-8f03-fafce051474b?mode=build&sha=03b8cfe173a9c20c08ef153bec6785dc399cb36b

After implementing, would you be able to check it against the History and Bookmark pages, to make sure that all the measurements match?

[mheubusch]

@brampitoyo Can you ensure that we have delivered the correct svg for the add-on icon so that it scales correctly?

[brampitoyo]

@mheubusch Thanks for checking in on this. I’ve gone through all the screens where the add-on icon appears, and it seems that we’ve used the right version everywhere – one that scales correctly.

It seems, from my end, that we’ve delivered the correct asset. Let’s double-check with @sflorean.

[sflorean]

@brampitoyo this issue is only reproducible if the Fennec is replaced by Fenix (migrated) and on Fennec we have some addons enabled that are not supported on Fenix.

1. Install Fennec http://archive.mozilla.org/pub/mobile/candidates/68.7b1-candidates/build1/android-api-16/.
2. Enable add-ons that are not yet available on Fenix.
3. Install Fenix https://firefox-ci-tc.services.mozilla.com/tasks/index/mobile.v2.fenix.fennec-beta.2020.06.27.revision.e0fa1c0db4ff806c991b13906ef6a30ba4d6054d.
4. Check the addons settings -> Not yet available.

Here is a screenshot from 78.0.1-beta.1 build:

[brampitoyo]

Hi @sflorean, our spec for the “Not yet supported” page can be viewed and inspected here:

https://share.goabstract.com/28d0811b-ffed-4863-89c8-8aaa10acb528?mode=design&sha=e00d4f002ecef58f001903d9111f95b864daa8ae

Compare the page above to the root Add-ons Manager page here:

https://share.goabstract.com/62fae84c-38fc-4b5f-a648-32e09b18ed36?mode=design&sha=31cd0fd41307935bad30f2cb0a009626db62007a

If we make the icons, frame, margins and separator on this “Not yet supported” page identical to the root Add-ons Manager page, we should be good to go.

Would you be able to post an example after making the change, so we can review one last time before the change lands?

Thanks!

[sflorean]

@brampitoyo, unfortunately, I can't make the changes given the fact that I'm not a developer, but a tester. But I can help with verifying the fix.

[brampitoyo]

@sflorean Understood. Ping @Amejia481 so that he can prioritise this issue in later sprints, when we have time.

[Mugurell]

Adding here also the update from Bram - "Our add-ons icon should follow the same guidelines as favicons (see mozilla-mobile/fenix#7992)." (https://github.com/mozilla-mobile/android-components/issues/8054#issuecomment-671750276)

[Mugurell]

With the merge of https://github.com/mozilla-mobile/android-components/issues/8054 (which contains updated specs from Bram) this should be ready to test in the next Nightly.

[sflorean]

We will check this on Beta/Release builds due to the fact that the Fennec Nightly migrated app is no longer displayed in Google Play.

[softvision-miralobontiu]

Hi all,
This issue is not fixed yet. I've done the following migrations using Samsung Galaxy Tab S6 (Android 9), and Sony Xperia Z5 Premium (Android 7.1.1):

• Fennec RC 68.9.0 to Fenix RC 79.0.5 - the same display of the "Not yet available" page,
• Fennec beta 68.7b1 to Fenix beta 80.0.1-beta.2 - the same display of the "Not yet available" page.

I'll remove the qa:needed label until further notice,

[Mugurell]

I see Fenix beta 80.0.1-beta.2 being released on August 18th while the patch to resolve this was merged in AC on August 20th.
So it is expected for these builds to not contain the fix.

Also note that the patch to resolve this added an icon background, similar to what the other addons icons have that should be visible regardless of the size of icon.

video

I'll readd the qa:needed label for this to be checked in later releases.

[ebalazs-sv]

Verified as fixed on Beta 81.1.0-beta.2 (Build #2015761657), GV 81.0, from 9/2 with Pixel 2 (Android 9) and Samsung Galaxy Tab S3 (Android 8).