Fenix: [Bug]uBlock Origin icon flicker

[AndiAJ]

Steps to reproduce

1.From the home screen tap the 3 dot button and open Settings.

1. From the "Advanced" section open "Add-ons".
2. Check the uBlock Origin icon.

Expected behavior

No UI issues.

Actual behavior

When opening the "Add-ons" the uBlock Origin flickers, sometimes displaying a puzzle (image) instead of the actual icon for a couple of seconds.

Device information

• Android device:
  • Google Pixel 3a XL (Android 10)
  • Google Pixel 3a (Android 9)
  • Huawei Mate 20 Lite (Android 8.1.0)
  • Samsung Galaxy S7 (Android 7.0.0)
  • OnePlus A3 (Android 6.0.1)
  • LG Nexus 4 (Android 5.1.1)

• Fenix version: Nightly Build #20360606 from 2/5

► Video

[csadilek]

We're loading icon in a separate thread so it comes in at a later time (we don't want to block on it), but we're thinking of adding an animation to make this smoother.

[Amejia481]

@AndiAJ this should be fixed now in the latest Nightly. Would you mind retesting? :)

[AndiAJ]

Hi @Amejia481 , I've just checked this matter on the latest Nightly Build #20550606 from 02/24 using the following devices:
• Google Pixel 3a XL (Android 10)
• Google Pixel (Android 10)
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• Sony Xperia Z5 Premium (Android 7.1.1)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

❌It seems that when using the "Dark" theme, the animation has some problems, namely the background pic (puzzle) is displayed causing transition inconsistency.

✔️ While using the "Light" theme everything seems to be properly working.

► Video Dark theme

► Video Light theme

[Amejia481]

Now we should go it, @AndiAJ it should be fixed now in the latest Nightly. Would you mind retesting?

[AndiAJ]

Hi @Amejia481 , unfortunately it's still reproducible on the latest Nightly Build #20560606 from 02/25 using the following devices:
• Google Pixel 3a XL (Android 10)
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Video

[Amejia481]

Thanks @AndiAJ,
It looks like the change didn't make it to the last snapshot, I will let you know as soon the change is in.

[Amejia481]

@AndiAJ the fix is now in the latest Nightly. could you please verify? Thanks in advance :)

[AndiAJ]

Hi, verified as fixed on the latest Nightly Build #20570604 from 02/26 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Video

Great job @Amejia481 ! ☺️

[Amejia481]

Thank you for the quick response ❤️