Fenix: [Bug] uBlock Origin's icon is crooked

Created on 5 Feb 2020 · 2Comments · Source: mozilla-mobile/fenix

Steps to reproduce

Go to Settings - Add-ons and observe the uBlock Origin's icon.

Expected behavior

The icon looks good.

Actual behavior

The icon looks bad. It is "forced" in a grey circle and it doesn't completely fit.

Device information

Android device: all
Fenix version: 2/5 Nightly build

Untitled

WebExtensions S2 engverified 🐞 bug

Source

softvision-miralobontiu

👍1

Most helpful comment

This should be fixed from AC in https://github.com/mozilla-mobile/android-components/pull/5827 to make it conform with the designs.

gabrielluong on 6 Feb 2020

🎉3 👍1

All 2 comments

This should be fixed from AC in https://github.com/mozilla-mobile/android-components/pull/5827 to make it conform with the designs.

gabrielluong on 6 Feb 2020

🎉3 👍1

Hi, verified as fixed on the latest Nightly #20380605 from 2/7 using the following devices:
• Google Pixel 3a XL (Android 10)
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7.0.0)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

@gabrielluong - Just a QQ, do you know why the shape of the icon is different from one device to another?
For E.g. on the Pixel devices the icon is round whereas on the other devices it looks "diamond shaped".

► Screenshot from Google Pixel 3a (Android 9)
rsz_screenshot_20200207-153613_1