Fenix: [Bug] After deleting the selected search engine, the next one selected is chosen randomly

[softvision-miralobontiu]

Steps to reproduce

1. Go to Settings - Search and delete the selected search engine.
2. Observe the next search engine that is automatically selected.

Expected behavior

The next search engine under the one deleted is automatically selected - as in the https://miro.com/app/board/o9J_kwAuqu4=/

Actual behavior

The search engine selected skips the next search engine and selects randomly.

Device information

• Android device: Google Pixel (Android Q), Samsung Galaxy Tab S3 (Android 8)
• Fenix version: 11/27 (#13310607)

UX

Design Work

• [x] Request for Comments from UX team
• [ ] ~Usability testing if a new pattern or potentially confusing UI~ Not required, this is a minor behaviour change
• [ ] ~Request for Comments from Fenix team and/or A/C, GV, Sync, etc as needed~ The behaviour change came from Fenix Engineering, UX is confirming it
• [x] Interaction details included
• [x] Accessibility ~- is this a review by someone,~ just keeping it in mind?
• [ ] ~For existing UI changes, deltas are highlighted~ No UI change, this is behaviour-only
• [ ] ~Strings/content reviewed and approved~ No new string
  
  
  
  • [ ] ~Are they too long for the component in other locales~
  
  

Deliverable

• [ ] ~Assets uploaded to Google Drive~
• [ ] ~Links to deliverables (spec, assets) posted in comment 0~
• [x] Behaviour

Deliverable Links

• [ ] ~User flow: (link to e.g. Abstract artboard, LucidChart, Whimsical, Miro, etc.)~
• [ ] ~Spec: (link to e.g. Abstract artboards)~
• [ ] ~Assets: (link to Google Drive folder)~

Behaviour

After a search engine is deleted from the list, the search engine listed on the very top of the list should be selected next.

[mcarare]

Question for UX: The recent changes from @boek result in that when the the selected engine is deleted the first one in the list will be selected.
IMO it actually makes more sense than selecting the next one in the list.
Should we keep this behaviour or implement the one suggested in the mocks?
TY!

[brampitoyo]

@mcarare Your and @boek’s proposal makes sense to us:

[…] when the the selected engine is deleted the first one in the list will be selected.

I will update comment 0 and my Miro specs with this decision.

[softvision-miralobontiu]

@brampitoyo just to be clear on the expected behavior: when the selected search engine is deleted, the first one in the list is selected automatically? I saw the new Miro specs:

[brampitoyo]

@softvision-miralobontiu Correct. As @mcarare wrote:

The recent changes from @boek result in that when the the selected engine is deleted the first one in the list will be selected.

I think this behaviour makes sense.

[brampitoyo]

Updated comment 0 with UX behaviour.

[AndiAJ]

Hi, I've just checked this matter on the latest Nightly build #13530608 from 12/19 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

It seems that when deleting search engines from the middle of the list or from Bottom :arrow_right: Top the second listed search engine is selected, and after the confirmation snackbar disappears it jumps to the first one.

✔️ Deleting the search engines Top :arrow_right: Bottom

❌ Deleting the search engines from the Bottom :arrow_right: Top

❌ Deleting search engines located in the Middle of the list

@mcarare - Please review. ☺️

[mcarare]

@AndiAJ please retest with the next Nightly.

[AndiAJ]

Hi, verified as fixed on the latest Nightly Build #13540607from 12/20 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

✔️ Deleting the search engines Top ➡️ Bottom

✔️ Deleting the search engines from the Bottom ➡️ Top

✔️ Deleting search engines located in the Middle of the list