Fenix: [Bug]Saved images are not properly names (can't open from in app notif, no name in notif)

Created on 8 Nov 2019  ·  8Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

  1. Navigate to theverge.com
  2. Long tap on one of the featured articles or images
  3. Select "Save image" from the context menu
  4. From the Android taskbar tap on the download confirmation to open the downloaded image

Expected behavior

The image should be opened after tapping the notification

Actual behavior

The downloaded image isn't opened after tapping the notification

Device information

  • Android device:
    • Google Pixel 3a XL (Android 10)
    • Google Pixel 3a XL (Android 9)
    • Huawei Mate 20 Lite (Android 8.1.0)

  • Fenix version:
    • Beta 3.0.0-beta.1 Build #13112229 from 7/11
    • Nightly Build #13120608 from 8/11

Notes

► Video
20191108_124622

Download S1 engverified 🐞 bug

All 8 comments

This is effectively the same issue as https://github.com/mozilla-mobile/fenix/issues/6576. Something is going wrong when downloading with "save image" that is causing both of these symptoms.

20191125_115945

So two things I've discovered:
1) The "open" fails because it's not pointing to the correct file name.
2) The download notification will open the image when tapped, so it is properly downloading, it's just not getting its file name properly set.

So two things I've discovered:

  1. The "open" fails because it's not pointing to the correct file name.
  2. The download notification will open the image when tapped, so it is properly downloading, it's just not getting its file name properly set.

@sblatz - You are right! :relaxed:

I've re-checked this matter and it is still reproducible on the latest Nightly Build #13310607 from 11/27 using the following devices:
• Google Pixel 3a XL (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)

► Video from Samsung S7 using Fenix
20191127_122500

► Video from Samsung S7 using Fennec
20191127_122704

Hi sorry about that, the AC version hadn’t been updated yet. It should be good to test in the next nightly!

@sblatz See https://github.com/mozilla-mobile/fenix/issues/6615#issuecomment-559784673
Tap Open on a saved image notification from wikipedia (no filename displayed), it will result in a can't load/open the file error.
Tap Open on the unsplash.com download (has filename displayed), it will open the file correctly.

Looks to be fixed 🎉

Untitled 2019-12-10 08_55_14

QA it should be in nightly tomorrow or working on master :)

Hi, verified as fixed on the latest Nightly Build #13450608 from 12/11 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• Motorola G4 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Video
20191212_124950

Was this page helpful?
0 / 5 - 0 ratings