Fenix: [Bug]Tracking protection not working

Created on 29 Oct 2019  Β·  14Comments  Β·  Source: mozilla-mobile/fenix

Prerequisites

Have tracking protection turned on globally and set to Strict mode

Steps to reproduce

  1. Navigate to https://mozilla.github.io/tracking-test/ads.html
  2. Navigate to https://senglehardt.com/test/trackingprotection/test_pages/ and select one by one the featured test pages.

Expected behavior

For 1. Confirmation that advertising resources are blocked should be displayed.
For 2. Having ETP set to Strict a confirmation saying Blocked on each test webpage

Actual behavior

For 1. Advertising resources are not blocked.
For 2. Only the Referrer Policy test page is blocked

Device information

  • Android device:
    Samsung Galaxy Tab A (Android 9)

  • Fenix version:
    β€’ 2.3.0-rc.1 from 28/10
    β€’ Nightly #13020608 from 29/10

Notes

β–ΊVideo 1. https://mozilla.github.io/tracking-test/ads.html
20191029_145156

β–ΊVideo 2. https://senglehardt.com/test/trackingprotection/test_pages/
20191029_154634

TrackingProtection S1 engverified 🐞 bug

Most helpful comment

Hi, I've just checked on the latest Nightly Build #13040608 from 31/10 using a Google Pixel 3a XL (Android 9) and noticed the following:

  1. βœ”οΈ https://mozilla.github.io/tracking-test/ads.html
    20191031_143014

  2. βœ”οΈ Checked ETP on different websites
    20191031_142613

  3. ❓ https://senglehardt.com/test/trackingprotection/test_pages/
    20191031_150502

β€’ Fingerprinting ONLY βœ”οΈ

β€’ Cryptomining ONLY βœ”οΈ

β€’ Fingerprinting and Cryptomining βœ”οΈ

β€’ Fingerprinting and Cryptomining and Trackers ❓
Basic Tracking Protection List (base-track-digest256):
NOT BLOCKED

β€’ Fingerprinting and Cryptomining and Cookies βœ”οΈ

β€’ Fingerprinting and Trackers - ❓
Basic Tracking Protection List (base-track-digest256):
NOT BLOCKED

β€’ Cryptomining and Trackers ❓
Basic Tracking Protection List (base-track-digest256):
NOT BLOCKED

β€’ Trackers and Cookies (Level 1 & Level 2) ❓
Level 1 (Basic) List -- Combined
Level 1 Tracker blocking with combined list (base-track-digest256)
base-track-digest256:
NOT BLOCKED

Level 2 (Strict List) Tracker Blocking
content-track-digest256:
NOT BLOCKED

Cookie blocking
NOTE: If tracker blocking is enabled, these tests might not run
Level 1 (Basic) List -- Combined

  • Advertising, Analytics, and Social - base-track-digest256:
    Cookies not blocked

β€’ Social Tracking Protection ❓
Tracker blocking (social-tracking-protection-digest256)
NOT BLOCKED
Cookie blocking (social-tracking-protection-digest256)
Result: Cookies not blocked

β€’ Social Tracking Protection and Fingerprinting ❓
STP Tracker blocking (social-tracking-protection-digest256)
NOT BLOCKED
STP Cookie blocking (social-tracking-protection-digest256)
Result: Cookies not blocked

β€’ Social Tracking Protection and Cryptomining ❓
STP Tracker blocking (social-tracking-protection-digest256)
NOT BLOCKED
STP Cookie blocking (social-tracking-protection-digest256)
Result: Cookies not blocked

β€’ Social Tracking Protection and Fingerprinting and Cryptomining ❓
STP Tracker blocking (social-tracking-protection-digest256)
NOT BLOCKED
STP Cookie blocking (social-tracking-protection-digest256)
Result: Cookies not blocked

@ekager , @Amejia481 - As you can see there are some Trackers and cookies that are not blocked.
Could you please review? I'm not sure if they should/shouldn't be blocked.

All 14 comments

Thanks for the report I'm taking a look at it!

We found the issue on AC and we put a patch for it, as soon it gets merged it will be fixed https://github.com/mozilla-mobile/android-components/pull/4877

I'm unable to reproduce the issue on releases/v2.3branch? Could please verify? In standard the tracker shouldn't be blocked but in strict the tracker must be blocked

@AndiAJ both of these videos are from Nightly it looks like? Because in v2.3 you shouldn't be able to see the TP shield in the toolbar.

This issue should be fixed for Nightly users with the next build since the AC changes were merged ~3 hours ago

@ekager - Yes, indeed the videos were from the Nightly build.

Due to the fact that on RC builds the shield and the 2 ETP settings options (Standard & Strict) aren't displayed I wanted to highlight that while having it set to Strict nothing is blocked.

To see the fix Fenix nightly has to use 20.0.0-SNAPSHOT as right now is using 19.0.0-SNAPSHOT

See https://github.com/mozilla-mobile/fenix/pull/6343

Now, this should be fixed

Hi, I've just checked on the latest Nightly Build #13040608 from 31/10 using a Google Pixel 3a XL (Android 9) and noticed the following:

  1. βœ”οΈ https://mozilla.github.io/tracking-test/ads.html
    20191031_143014

  2. βœ”οΈ Checked ETP on different websites
    20191031_142613

  3. ❓ https://senglehardt.com/test/trackingprotection/test_pages/
    20191031_150502

β€’ Fingerprinting ONLY βœ”οΈ

β€’ Cryptomining ONLY βœ”οΈ

β€’ Fingerprinting and Cryptomining βœ”οΈ

β€’ Fingerprinting and Cryptomining and Trackers ❓
Basic Tracking Protection List (base-track-digest256):
NOT BLOCKED

β€’ Fingerprinting and Cryptomining and Cookies βœ”οΈ

β€’ Fingerprinting and Trackers - ❓
Basic Tracking Protection List (base-track-digest256):
NOT BLOCKED

β€’ Cryptomining and Trackers ❓
Basic Tracking Protection List (base-track-digest256):
NOT BLOCKED

β€’ Trackers and Cookies (Level 1 & Level 2) ❓
Level 1 (Basic) List -- Combined
Level 1 Tracker blocking with combined list (base-track-digest256)
base-track-digest256:
NOT BLOCKED

Level 2 (Strict List) Tracker Blocking
content-track-digest256:
NOT BLOCKED

Cookie blocking
NOTE: If tracker blocking is enabled, these tests might not run
Level 1 (Basic) List -- Combined

  • Advertising, Analytics, and Social - base-track-digest256:
    Cookies not blocked

β€’ Social Tracking Protection ❓
Tracker blocking (social-tracking-protection-digest256)
NOT BLOCKED
Cookie blocking (social-tracking-protection-digest256)
Result: Cookies not blocked

β€’ Social Tracking Protection and Fingerprinting ❓
STP Tracker blocking (social-tracking-protection-digest256)
NOT BLOCKED
STP Cookie blocking (social-tracking-protection-digest256)
Result: Cookies not blocked

β€’ Social Tracking Protection and Cryptomining ❓
STP Tracker blocking (social-tracking-protection-digest256)
NOT BLOCKED
STP Cookie blocking (social-tracking-protection-digest256)
Result: Cookies not blocked

β€’ Social Tracking Protection and Fingerprinting and Cryptomining ❓
STP Tracker blocking (social-tracking-protection-digest256)
NOT BLOCKED
STP Cookie blocking (social-tracking-protection-digest256)
Result: Cookies not blocked

@ekager , @Amejia481 - As you can see there are some Trackers and cookies that are not blocked.
Could you please review? I'm not sure if they should/shouldn't be blocked.

I will send some print screens to clarify how each page should look like per tracking protection policy (Standard and Strict)

Standard (We are only blocking cookies + CRYPTOMINING)

Fingerprinting ONLY (We are not blocking Fingerprinting in Standard)

Screenshot_20191031-094247

Cryptomining ONLY

Screenshot_20191031-094437

Fingerprinting and Cryptomining (We are not blocking Fingerprinting in Standard)

Screenshot_20191031-094652

Fingerprinting and Cryptomining and Trackers (We are not blocking Fingerprinting in Standard)

Screenshot_20191031-094919

Fingerprinting and Cryptomining and Cookies (We are not blocking Fingerprinting in Standard)

screenshot-1572533459769

Fingerprinting and Trackers (We are not blocking Fingerprinting in Standard)

screenshot-1572533778238

Cryptomining and Trackers

screenshot-1572533865707

Trackers and Cookies (Level 1 & Level 2)

screenshot-1572533989022

screenshot-1572534005319

Social Tracking Protection

screenshot-1572534176818

Social Tracking Protection and Fingerprinting (We are not blocking Fingerprinting in Standard)

screenshot-1572534239625

Social Tracking Protection and Cryptomining

screenshot-1572534292612

Social Tracking Protection and Fingerprinting and Cryptomining (We are not blocking Fingerprinting in Standard)

screenshot-1572534385994

STRICT (We are blocking content from loading + AD+ ANALYTICS+ SOCIAL + CRYPTOMINING+ FINGERPRINTING )

Fingerprinting ONLY

screenshot-1572535330550

Cryptomining ONLY

screenshot-1572535408374

Fingerprinting and Cryptomining

screenshot-1572535553903

Fingerprinting and Cryptomining and Trackers

screenshot-1572535674351

Fingerprinting and Cryptomining and Cookies (We are not blocking Fingerprinting in Standard)

screenshot-1572535793103

Fingerprinting and Trackers

screenshot-1572535892029

Cryptomining and Trackers

screenshot-1572535990388

Trackers and Cookies (Level 1 & Level 2)

screenshot-1572536185084
screenshot-1572537022612

Social Tracking Protection

screenshot-1572538278747

Social Tracking Protection and Fingerprinting

screenshot-1572538351516

Social Tracking Protection and Cryptomining

screenshot-1572538423317

Social Tracking Protection and Fingerprinting and Cryptomining (We are not blocking Fingerprinting in Standard)

screenshot-1572538074441

Hi, verified as fixed on the latest Nightly Build #13050627 from 1/11 using a Google Pixel 3a XL (Android 9)

β–Ί Standard
20191101_111853

β–Ί Strict
20191101_112037

@Amejia481 - Many thanks for helping me out ! :smiley:

You are welcome @AndiAJ !

Was this page helpful?
0 / 5 - 0 ratings