Fenix: [Bug] Firefox Preview crashing when file picker tries to open

[KWierso]

Steps to reproduce

Open a page with an "attach file" button (signed in twitter or facebook are what I've tried).
Tap the "attach file" button.

Expected behavior

The file picker should open, and I should be able to attach an image to the tweet or facebook post.

Actual behavior

Firefox crashes, rather than opening the file picker ui.

Device information

• Android device: Pixel 3, Android 10
• Fenix version: Nightly 191025 06:21 (Build #12980628)
  I had this issue prior to this morning's Fenix Nightly update, unsure what the older build version was.

[KWierso]

I've also hit this crash trying to upload a file to onedrive.live.com, so it's not just the image picker that's hitting this, it's any file picker, as far as I can tell.

[pocmo]

Caused by AC issue: https://github.com/mozilla-mobile/android-components/issues/4854

[pocmo]

Is any release / RC affected so that we'd need to uplift the AC fix?

[KWierso]

This only started for me three days ago on Nightly, so unless the offending change was upliftedsince then, I doubt it.

I don't have anything other than Nightly installed to prove that, though.

[AndiAJ]

Hi, verified as fixed on the latest Nightly Build #13040608 from 31/10 using the following devices:
• Google Pixel 3a XL (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Twitter
✔️ Add profile picture
✔️ Create a tweet containing pictures and videos

► Instagram
✔️ Add profile picture
✔️ Share a photo

► Facebook
✔️ Add profile picture
✔️ Create a post containing pictures and videos

► Gmail
✔️ Attach pictures and videos while composing a new email

[softvision-oana-arbuzov]

@AndiAJ I was able to reproduce the issue when trying to add photo in a post on Facebook.

Tested with:
Browser / Version: Firefox Preview Nightly 191108 06:01 (Build #13120608) 📦: 21.0.0, 09da19708 🦎: 72.0a1-20191105095755
Operating System: Huawei P20 Lite (Android 8.0.0) - 1080 x 2280 pixels, 19:9 ratio (~432 ppi density)

[sv-ohorvath]

@NotWoods see comment above

[sv-ohorvath]

Is any release / RC affected so that we'd need to uplift the AC fix?

@pocmo v3.0.0-beta 1 is affected.

[cadeyrn]

The current stable release Fenix 2.3.0 is also affected.

[pocmo]

Are you able to reproduce that with Nightly?

[massic80]

I just tested with Nightly 191109 06:20 (Build #13130627) and still got a crash.

[TitanNano]

https://photos.google.com is also affected by this. https://mail.google.com on the other hand not.

[NotWoods]

This may be caused by conflicting file providers for downloads and the file picker. The original cause has been resolved but a new crash showed up.

[NotWoods]

Assigning to @Amejia481 since he's working on a fix for the new crash bug

[Amejia481]

This should be fixed on nightly

[KWierso]

Opening the file picker on Facebook in my Firefox Preview Nightly did not crash.

[massic80]

I confirm for Facebook

[julienw]

This works on Twitter too now. Thanks for the fix!

[softvision-miralobontiu]

Verified as fixed on the latest Nightly build 11/25 with Google Pixel 3 (Android Q), and Huawei P9 Lite (Android 7).

[SoftVision-PaulOiegas]

Is any release / RC affected so that we'd need to uplift the AC fix?

Sadly this reproduces also on Release version 2.3.0 (Build #13031728) on my Huawei P30.

Experienced the crash on Google desktop website when trying to upload a picture for search and on a market website where I wanted to attach an image for a product review. Might wanna consider that uplift. 😁

[cadeyrn]

FWIW there was a AC dot release (18.0.1) two weeks ago only for this issue so that a bugfix release for Fenix can be shipped to fix the bug for release users but it never happened. Considering the really large number of reports the last few weeks and that 3.0.0 won't be released before December I still think a bugfix update 2.3.1 should be released.