Fenix: [Bug]"Search with" and "Search or enter address" strings improperly positioned in RTL

[AndiAJ]

Prerequisites

Have RTL enabled in Developer options

Steps to reproduce

1. Tap on the search bar
2. Check the position of the "Search or enter address" from the search bar
3. "Search with" above the search shortcuts

Expected behavior

Should be properly positioned

Actual behavior

"Search or enter address" string to close to the left edge of the search box
"Search with" to close to the right edge of the display

Device information

• Android device:
  • Google Pixel 3a XL (Android 9)
  • Samsung Galaxy Note 9 (Android 8.1.0)
  • Samsung Galaxy S7 (Android 7)
  • LG Nexus 4 (Android 5.1.1)

• Fenix version: Nightly Build #12980627 from 25/10

Notes

Related to #5497

[brampitoyo]

Thanks for reporting, @AndiAJ. You’re right that this is a bug.

We also know exactly what to do in order to fix this issue. The amount of padding should be identical to the padding on LTR layout.

[AndiAJ]

Hi, check on the latest Nightly Build #13110606 from 7/11 using the following devices:
• Google Pixel 3a XL (Android 9)
• Samsung Galaxy S7 (Android 7)
• LG Nexus 4 (Android 5.1.1)

1. "Search with" ✔️
   
   

2. "Search or enter address" ❌
   
   

@BranescuMihai - I would kindly ask you to review the remaining issue. 😊
I'll remove the QA needed label until further clarifications.

[mcarare]

waiting on https://github.com/mozilla-mobile/android-components/issues/4907

[darkwing]

@BranescuMihai How is this coming along? Any update you can provide?

[darkwing]

Hello @BranescuMihai! I see you have a PR merged in AC but I'm seeing this in Fenix today:

Should this be part of your AC patch? Anything more we need to do on our side?

[BranescuMihai]

@darkwing I think that is the expected UI. If you're on a language with no translation for 'Search or enter address' string, it will show up in English, but now it has some padding.

[Diana-Rus]

Hi, for "Search or enter address"- the padding looks good, it's not close anymore to the search box edge, verified as fixed on Firefox Preview Nightly 200325 (Build #20850608) GV: 76.0a1-20200323092419 with:
RTL:

• Google Pixel 3 XL (Android 9)
  

• Samsung Galaxy S9 (Android 8)
  

• Sony Xperia Z5 (Android 7)

The issue has been verified:

• in Normal mode
• in Private mode
• and with Dark theme applied