Fenix: Enable/Disable WebExtensions

Created on 18 Oct 2019  ·  7Comments  ·  Source: mozilla-mobile/fenix

User Story

As a user, I want to be able to disable a WebExtension (without uninstalling) so I have control over when I use each WebExtension.

Dependencies

A-C project board

Acceptance Criteria

  • I can choose to disable a WebExtension
  • I can choose to enable a WebExtension
WebExtensions engverified s

Most helpful comment

@AndiAJ the infinite loop when toggling should no longer happen. Can you re-verify, please?

All 7 comments

Progress report:

  • This one is fairly straightfoward. We’ve decided that this control should take the form of an ON/OFF toggle.
  • We also acknowledge the fact that this feature is important for Fennec to Fenix migration. Migrated add-ons from Fennec can be automatically installed on Fenix, but we may choose to turn them OFF by default.

Hi, I've just checked this matter on the latest Fenix Nightly #20360606 from 2/5 using the following devices:
• Google Pixel 3a XL (Android 10)
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7.0.0)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

On all devices I've noticed that if you consecutively enable/disable 3x the Ublock Addon will generate and endless (enable/disable) loop.

► Video
20200205_102423

Another worth mentioning matter is the Crash on the LG Nexus 4 (Android 5.1.1) filled in #8097 wich seem to be occurring quite randomly.

@csadilek & @brampitoyo - Please review and share your thought on how should we proceed with this matter. ☺️

I'll remove the QA needed label until further notice.

@AndiAJ Thanks for catching this issue. No. The endless loop shouldn’t happen.

@csadilek I wonder what’s causing this issue?

Another worth mentioning matter is the Crash on the LG Nexus 4 (Android 5.1.1) filled in #8097 wich seem to be occurring quite randomly.

@AndiAJ @brampitoyo We've landed a fix for this crash today, but the infinite loop when toggling multiple time quickly is likely not fixed by that. We'll put a fix up tomorrow /cc @Amejia481 (I think we fixed that one before).

Sure, I'm taking a look at it!

@AndiAJ the infinite loop when toggling should no longer happen. Can you re-verify, please?

Hi, verified as fixed on the latest Nightly #20380605 from 2/7 using the following devices:
• Google Pixel 3a XL (Android 10)
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7.0.0)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Video
20200207-122745

Was this page helpful?
0 / 5 - 0 ratings