Fenix: Redesign About page in Settings

[lime124]

pulling up Amy's comment from below:

Here is the updated mock with additional items we would like to include. Please note that this is a long list so please allow for page scrolling when adding additional items. Thanks!

What’s new in Firefox Preview (in current build) - https://support.mozilla.org/en-US/kb/whats-new-firefox-preview

Support - https://support.mozilla.org/en-US/products/firefox-preview

Privacy notice - https://www.mozilla.org/en-US/privacy/firefox/

Know your rights - about:rights

Licensing Information - about:license

GeckoView libraries we use (in current build)

Other open source libraries we use (in current build)

TBD Release Notes - need to confirm if we have these, @Tif will reach out to Joni Chan

[lime124]

@vesta0 this should be pretty small. it would be nice to get in if we have a bit of time.

[AmyYLee]

Let me know if there's anything else that needs to be added here:

[NotWoods]

@AmyYLee Is this ready for eng?

[vesta0]

@lime124 please review Amy's design and let us know if this is ENG ready so we can size it during backlog grooming on Wednesday.

[lime124]

@AmyYLee for a few technical reasons, we need to call out gv libraries separately. Can you add a third row a the bottom under "Open source..." for this. Same layout and styling.

Text suggestion: "GeckoView libraries we use"

let me ping michelle to see who jeff's back up is. once Amy updates and we have final string we can label ready for eng. thanks!

Update see Michelle's comment below for order and string.

[lime124]

@mheubusch can confirm the copy suggested in my prior comment. thanks!

[mheubusch]

I recommend this order/text:
What's new in Firefox Preview
GeckoView libraries we use
Other open source libraries we use

[AmyYLee]

@lime124 @mheubusch I've updated the mock with the updated copy. This is ready for eng.

Mock

[Amejia481]

@AmyYLee I think the section "GeckoView libraries we use" should be renamed to "Mozilla libraries we use", as we use two major libraries from Mozilla Geckoview and Android Components

[vesta0]

Hey @AmyYLee sorry to add more requirements after you have already completed working on this ticket but I think it will be easier to do this in one go. Would you please take a look at the Fennec About page below and make sure you have considered all these options? I don't think we need to include all of them but want to make sure that you have considered them all.

FYI @lime124

[AmyYLee]

@lime124 @vesta0 I reviewed what was in Fennec and either found a Preview equivalent or the same link if it applies to Preview as well and also open questions either one of you. Please see below:

FAQ - Do we have a page for Preview? I found Fennec but couldn't find one for Preview (Do we need one?) - I think if we have one it doesn't hurt to add it but if we don't we can leave this out.

Support - https://support.mozilla.org/en-US/products/firefox-preview (We should have this)

Privacy Policy - https://www.mozilla.org/en-US/privacy/firefox/ (We should have this)

Know your rights - about:rights (We should have this)

What’s new in Firefox Preview - https://support.mozilla.org/en-US/kb/whats-new-firefox-preview (We should have this)

Release Notes - I couldn't find Preview release notes, who should I reach out to find that? (We should have this)

Credits - Do we have a list? Do we need it? - I don't think we need this if we don't already have a list.

Licensing Information - about:license (We should have this)

[AmyYLee]

@lime124 @vesta0 Hi, I also noticed that the screenshot you posted is the "about:firefox" page and not the the "Mozilla Firefox" page that is in-app to Fennec. This is more equivalent I think

[lime124]

@ joni chen - does fenix have release notes that we can point in the app?

@vesta0 - we don't have credit or an FAQ page. amy and i don't think a credit page is necessary at this point, but please feel free to file follow up bugs for either credits or FAQ and the ux team can figure out designs and where they go in the settings.

[AmyYLee]

Hi,

Here is the updated mock with additional items we would like to include. Please note that this is a long list so please allow for page scrolling when adding additional items. Thanks!

What’s new in Firefox Preview (in current build) - https://support.mozilla.org/en-US/kb/whats-new-firefox-preview

Support - https://support.mozilla.org/en-US/products/firefox-preview

Privacy notice - https://www.mozilla.org/en-US/privacy/firefox/

Know your rights - about:rights

Licensing Information - about:license

GeckoView libraries we use (in current build)

Other open source libraries we use (in current build)

---

TBD Release Notes - need to confirm if we have these, @tif will reach out to Joni Chan

[lime124]

can this be picked up by a contributor? are there dependencies?

[lime124]

i reached out to joni. if release notes are required and depending on timing, we can either update the mock in this issue or create a follow up .

[NotWoods]

I think this can be picked up by contributors. Except for the bottom two items, all the links should open a new web page. We should probably open custom tabs similar to the support menu that already exists.

[lime124]

removing @AmyYLee and @Baron-Severin to signal this issue is free to be picked up.

[vesta0]

@lime124 @AmyYLee sorry for delay in responding. I agree with your recommendations.

I will file a bug for FAQ or Credits page if needed.

[ValentinTimisica]

I'm working on this and I have a few questions:

• I saw in the mock that the links are hardcoded but in the app getSumoURLForTopic is used to get a dynamic page URL, based on locale, app version etc.
  For example, for What's new in Firefox Preview the new specifications say that we should use
  "https://support.mozilla.org/en-US/kb/whats-new-firefox-preview"
  but using current method from AboutFragment would get us
  "https://support.mozilla.org/1/mobile/1.0.1947/Android/en-GB/whats-new-firefox-preview"
  I don't think we should use the hardcoded links because this will impact users with different locales.
  Should all the new provided links use the same schema (with locale, app version etc) from SumoTopic? In this case the new sumo pages will have to be created for
  
  
  
  • Support
  
  
  • Privacy Notice
  
  

Please also note that the "about:rights" page also does not exists yet in the app.

• For the last two items it's not clear what we should display.
  
  
  
  • For the Other open source libraries we use should we use the old link for Open source libraries we use?
  
  
  • What we should display for GeckoView libraries we use?
  
  

[AmyYLee]

I'm working on this and I have a few questions:

* I saw in the mock that the links are hardcoded but in the app [getSumoURLForTopic](https://github.com/mozilla-mobile/fenix/blob/c9e4303fa03b8dbcfc21c804571750d7be01ce6e/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt#L39) is used to get a dynamic page URL, based on locale, app version etc.
  For example, for `What's new in Firefox Preview` the new specifications say that we should use
  "https://support.mozilla.org/en-US/kb/whats-new-firefox-preview"
  but using [current method from AboutFragment](https://github.com/mozilla-mobile/fenix/blob/c9e4303fa03b8dbcfc21c804571750d7be01ce6e/app/src/main/java/org/mozilla/fenix/settings/AboutFragment.kt#L79) would get us
  "https://support.mozilla.org/1/mobile/1.0.1947/Android/en-GB/whats-new-firefox-preview"
  I don't think we should use the hardcoded links because this will impact users with different locales.

  Should all the new provided links use the same schema (with locale, app version etc) from [SumoTopic](https://github.com/mozilla-mobile/fenix/blob/c9e4303fa03b8dbcfc21c804571750d7be01ce6e/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt#L26)? In this case the new sumo pages will have to be created for

  * Support
  * Privacy Notice

I agree we should be using links that support different locales. I’m not sure how we can go about getting links for Support and Privacy Notice. @NotWoods can you confirm?

Please also note that the "about:rights" page also does not exists yet in the app.

We have “about:rights” and “about:license” in Fennec. How do we go about getting these for Fenix? @NotWoods

* For the last two items it's not clear what we should display.

  * For the `Other open source libraries we use` should we use the old link for `Open source libraries we use`?
  * What we should display for `GeckoView libraries we use`?

@Amejia481 Do you know what libraries we should link to?

@ValentinTimisica Also minor edit to the copy. Can you change "GeckoView libraries we use" to "Mozilla libraries we use"

Thanks

[Amejia481]

@Amejia481 Do you know what libraries we should link to?

If we want to have a separate section for Mozilla libraries and for non Mozilla Libraries, we should have:

• Mozilla libraries we use: Android Components and GeckoView.
• Third party libraries we use: all third party libraries

I think we can just have one section for all libraries "Libraries that we use"

[AmyYLee]

@Amejia481 Do you know what libraries we should link to?

If we want to have a separate section for Mozilla libraries and for non Mozilla Libraries, we should have:

* **Mozilla libraries we use**: Android Components and GeckoView.

* **Third party libraries we use**: all third party libraries

I think we can just have one section for all libraries "Libraries that we use"

I agree let's consolidate and use "Libraries that we use" - see mock above. @ValentinTimisica Also can you remove "Privacy notice" and "Help" from the Settings page now that we are moving this into the About page. Thanks

[ValentinTimisica]

Thanks all for your responses!
There is still one questions about the Know your rights item:

• We already had in Settings page this link for 'Your Rights': https://support.mozilla.org/1/mobile/1.0.1947/Android/en-GB/your-rights
  Should I use this instead of 'about:rights' which looks much too basic and also has to be implemented from scratch (right now "about:rights" page does not exists in the app )?

In Fennec the 'about:rights' page looks like this:

[liuche]

Hi @ValentinTimisica if you're working on this can you move it into the In-Progress column of the kanban? https://github.com/mozilla-mobile/fenix/projects/9

[AmyYLee]

Thanks all for your responses!
There is still one questions about the Know your rights item:

* We already had in Settings page this link for 'Your Rights': https://support.mozilla.org/1/mobile/1.0.1947/Android/en-GB/your-rights
  Should I use this instead of 'about:rights' which looks much too basic and also has to be implemented from scratch (right now "about:rights" page does not exists in the app )?

In Fennec the 'about:rights' page looks like this:

@ValentinTimisica Hi, thanks for pointing this out. Please use 'Your Rights': https://support.mozilla.org/1/mobile/1.0.1947/Android/en-GB/your-rights

[ValentinTimisica]

In the current implementation I saw that the item click events are tracked (example for Whats's new item). Should I create a new task for adding telemetry to all the new introduced items?

[AmyYLee]

In the current implementation I saw that the item click events are tracked (example for Whats's new item). Should I create a new task for adding telemetry to all the new introduced items?

@ValentinTimisica This would be great if it doesn't require a lot of additional effort. Thank you.

[nt1m]

FWIW, we do have a credits page: https://www.mozilla.org/credits/

[softvision-miralobontiu]

Hi all!
The design in Settings - About in the latest Nightly from 12/17 is:

I've encountered an issue on Google Pixel (Android Q) regarding the "Privacy notice" page.

Thanks!