Fenix: [Bug] noticeable movement of "Shortcuts" button when tapping the address bar

Created on 6 Aug 2019  ·  6Comments  ·  Source: mozilla-mobile/fenix

Actual behavior

There was a recent change to show all the search engines when tapping the address bar. This causes a movement of the "Shortcuts" button which is much more visible than before. It was not a problem before this change because the "Shortcuts" button was not active and you didn't notice the movement from bottom to top. But now the button has an active state by default and after tapping the address bar you first the blue button on the bottom and then you see how it moves to the top which is very noticeable. That's bad for the _perceived performance_ of Fenix.

Expected behavior

You should not notice the movement of a blue button from the bottom to the top. Maybe set the active status after the transition and not before?

Device information

  • Android device: HTC U11 / Android 9.0
  • Fenix version: master branch revision 3c1ce90f6f8ab6478b498ec9fdf5ab59831255bc
Search P2 S2 engverified UX-feedback 🐞 bug

Most helpful comment

@AmyYLee Unless you see an issue here, I think we should close this.

All 6 comments

@lime124 @cadeyrn Is this still reproducible? I'm not seeing it on the latest build from master.

I think it looks okay now. But please note that I have a much faster device now, I can no longer speak about the HTC U11.

It looks okay on LG K4 (android 6) as well.

Hi, I've re-check this matter on the latest Nightly #20420611 from 2/11 using the following devices:
• Google Pixel 3a XL (Android 10)
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7.0.0)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Video from Samsung Galaxy S7
20200212-222209

Time lapsed video from Samsung Galaxy S7
20200212-222315

@cadeyrn - Not sure if this was the issue that you've encountered by you in the past?
Could you please review and share your thoughts? ☺️

@AmyYLee Unless you see an issue here, I think we should close this.

@AmyYLee Unless you see an issue here, I think we should close this.

@darkwing yes please close this.

Was this page helpful?
0 / 5 - 0 ratings