Fenix: FNX3-16953 ⁃ [Bug] downloads from Firefox Send don't work
- [ ] Being investigated in GV bug https://bugzilla.mozilla.org/show_bug.cgi?id=1432949#c22
Steps to reproduce
- upload a file to send.firefox.com
- copy the download URL
- open the download URL
- press the "Download" button
- confirm that you want to download the file
Expected behavior
Fenix downloads the file.
Actual behavior
There is an Android notification:
<Untitled>
Download unsuccessful.
Not only that the download fails, also the "Untitled" is… interesting.
Device information
- Android device: HTC U11 / Android 8.0
- Fenix version: Fenix revision 4d82c297432e0f86d54e2d3496e0654bbb36a447
cadeyrn
All 25 comments
Expect that this is similar or dupe of #1657
kbrosnan
on 12 Jun 2019
I can verify that downloading from Firefox Send works with the new Gecko based download manager.
cadeyrn
on 3 Aug 2019
On master 4fc4759e, I tried uploading and downloading from Firefox Send. The download succeeded with the right filename, but I instead got a 12-byte file containing Unauthorized.
nyanpasu64
on 4 Aug 2019
Oh, you're right. I have only tested if the download works but I didn't open the file. I can confirm that Fenix downloaded a useless 12 byte file. :(
Since #1657 didn't fix this - can this issue be reopened, please?
/cc @NotWoods to let you know about this issue because you worked on the Gecko based download manager. :)
cadeyrn
on 4 Aug 2019
Looks like Firefox Send just returns the "Unauthorized" response to Fenix everytime, no matter the downloading system we use. I'll follow up with their team during the week.
Adding the "needs:gv" label in case GeckoView messes with Firefox Send somehow.
NotWoods
on 4 Aug 2019
How about trying a TLS MITM, downloading from Firefox Send, and capturing the packets to see if there's any errors in the HTTP headers, or extraneous duplicate requests? (or maybe logging packet headers in the app rather than in packet capture)
I observed that KDE's url opener sends a pre-flight request to check which app to forward the URL to. The request has no cookies, and causes problems, so I turn it off.
nyanpasu64
on 4 Aug 2019
GV bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1572813
Firefox Send breaks in Fenix due to a compat issue with Gecko Service Workers, possibly related to e10s in GV.
In the GV bug, Tiger wrote:
If GeckoView has the same behaviour then the Send team can whitelist it like Safari.
Should the Send team temporarily whitelist Fenix until we fix this GV bug? To whitelist Fenix but not Fennec, Send can check the User-Agent string:
Gecko version <= 68 is Fennec.
Gecko version >= 69 is Fenix.
cpeterso
on 29 Aug 2019
I've asked the Send team to whitelist Fenix for now.
NotWoods
on 29 Aug 2019
@NotWoods
I've asked the Send team to whitelist Fenix for now.
It's still an issue. Was there any feedback from the Send team?
Would be really great if the problem could be solved. Not because Firefox Send is such an important service but because Firefox services should work in Firefox browsers at least, I guess. ;-)
cadeyrn
on 25 Sep 2019
Firefox Send is planning to fix this bug. I'll see if there's an issue filed I can link to here.
NotWoods
on 25 Sep 2019
Filed mozilla/send#1404. Send tried to fix the issue already but that didn't work out, so we need to investigate more.
NotWoods
on 25 Sep 2019
Filed mozilla/send#1404. Send tried to fix the issue already but that didn't work out, so we need to investigate more.
@NotWoods , does "we need to investigate more" mean the Send team, the Fenix team, or the GV team? 😅
cpeterso
on 25 Sep 2019
Honestly I have no clue where the issue is now. 🙂
I left instructions for the Send team to debug since they know how the product works the best.
NotWoods
on 25 Sep 2019
TBD whether this fix requires a Service Workers fix in Gecko.
cpeterso
on 12 Nov 2019
Having the same or similar problem. See the screenshots attached.
Version: Firefox Preview 3.0 nightly 200215 06:00
bashims
on 15 Feb 2020
Umm. Today, decryption seems to work well. As mentioned at https://github.com/mozilla-mobile/fenix/issues/2579#issuecomment-597365647 , I doubt that Fenix is not able to download files from the URL of the blob where the decrypted data is stored.
cat-in-136
on 17 Apr 2020
@kglazko Have a look at these and the other linked bugs, maybe they give some more insight into STRs for some downloads problems or paths to look into?
One workaround mentioned is "changing settings to request desktop site."
liuche
on 5 May 2020
Should take a look into whether or not this is a Firefox Send issue, or another Downloads issue, like a spike.
liuche
on 14 May 2020
Should take a look into whether or not this is a Firefox Send issue, or another Downloads issue, like a spike.
It is being investigated in this gv bug https://bugzilla.mozilla.org/show_bug.cgi?id=1432949#c22
Amejia481
on 15 May 2020
I noticed that the issue was resolved in Bugzilla 31 minutes ago, does this mean this ticket will be addressed? @Amejia481
kglazko
on 21 May 2020
I noticed that the issue was resolved in Bugzilla 31 minutes ago, does this mean this ticket will be addressed? @Amejia481
We need to test with the latest GV version
Amejia481
on 21 May 2020
This should be fixed on master, QA please help us to verify, thanks in advance.
Amejia481
on 25 May 2020
It looks like the new AC version hasn't being updated, we need this version to land first https://github.com/mozilla-mobile/fenix/pull/10820
Amejia481
on 25 May 2020
Now the new version of ac has landed we are ready to test!
Amejia481
on 26 May 2020
Verified as fixed on the latest Nightly build from 5/27 with Google Pixel (android 10), and Sony Xperia Z5 Premium (Android 7.1.1).
softvision-miralobontiu
on 27 May 2020
Related issues
Mugurell
·
48Comments
Poopooracoocoo
·
60Comments
Cheap-Skate
·
67Comments
serovar
·
49Comments
djdisodo
·
108Comments
Most helpful comment
Verified as fixed on the latest Nightly build from 5/27 with Google Pixel (android 10), and Sony Xperia Z5 Premium (Android 7.1.1).