Fenix: Granular options for clearing user data in Fenix

[vesta0]

User Story

• As a user, I want to have the option of clearing different types of personal data, so I can have more control over what I choose to keep or delete.

Types of personal data:

-Open Tabs
-Browsing history
-Search history
-Cookies and site data
-Cached images and files
-Site settings

Requirements

• Behind a Feature Flag so QA can spend extra time testing

Acceptance Criteria

• I can choose what type of user data to delete at any time

UX Spec (strings are done).
https://mozilla.invisionapp.com/share/63TIO0DPXTS

[lime124]

removing the ux label - this is on our radar already as it's part of Q3 plans.

[liuche]

Also look at #3700 because they seem like they'll be similar UI.

[liuche]

QA has said they'd like a little extra time to test this, so this should be ideally behind a feature flag.

[liuche]

Still some outstanding work, but should be resolved by 8/19.

[cpeterso]

GV 68 already has a clearData API that can selectively delete user data by _type_ (e.g. all cookies, all network cache) but not by individual domain or time period (e.g. clearing all user data from the last 1 hour).

https://mozilla.github.io/geckoview/javadoc/mozilla-central/org/mozilla/geckoview/StorageController.html#clearData-long-

https://mozilla.github.io/geckoview/javadoc/mozilla-central/org/mozilla/geckoview/StorageController.ClearFlags.html

https://bugzilla.mozilla.org/show_bug.cgi?id=1489669

[colintheshots]

Wait. The UX says "Site Permissions", but the user story says "Site Settings". Those are two, different things. We already have a screen that lets the user delete all site permissions. The new deletion options is Site Settings. I think we need to separate out that part of this story and get new strings to complete it properly. What should the new title and subtitle be? @mheubusch

[colintheshots]

I'll complete the story as written and we can update the code later to support what we intended.

[jpfaller]

Verified the string as written (Site Permissions) is ok with @colintheshots

[colintheshots]

This is behind a feature flag in Nightly for now.

[andreicristianpetcu]

@colintheshots which flag?

[cadeyrn]

@colintheshots which flag?

https://github.com/mozilla-mobile/fenix/blob/2b9efccfca4ef23a48e19c7934955a0bff32a409/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt#L44

[colintheshots]

Moving to 2.1, since it hasn't been QA tested since merged and is still behind a feature flag.

[neekless]

Will we eventually get even finer granularity i.e. Delete per site/domain?

[AndiAJ]

Hi, all options work properly from a functional point of view.

On the other hand, I've found a couple of minor issues on the latest Nightly Build #12590611 from 16/9 using a Google Pixel 3a (Android 9) as it follows:
• The delete browsing data is always enabled
• "Fenix" string placeholder %s is displayed in the confirmation pop-up message.

►Video

I'll remove the QA needed label, until further clarifications.

[ekager]

Thanks @AndiAJ ! I opened https://github.com/mozilla-mobile/fenix/issues/5465 as a followup.