Fenix: FNX3-16418 ⁃ [Bug] Too many 3-dots menus on the history list

[Lululalu]

Steps to reproduce

Go to the history

Expected behavior

Only on menu at the top right

Actual behavior

There is one menu for each history entry, with only one option (delete). This could be avoided by swiping to delete. When history entries are selected, multiple menus are even less needed.

Device information

• Android device: Galaxy A5
• Fenix version: 1.0.1920

[cadeyrn]

There are few menu items which can be added, see #2435.

[Lululalu]

@cadeyrn In this case, at least when multiple entries are selected, the multiple menus could be hidened.

[lime124]

@topotropic to confirm that we intend to add additional items in the menu for history as per your comment: https://github.com/mozilla-mobile/fenix/issues/2435#issuecomment-494156479

in the case of multi-select of history items, we should be hiding the individual 3 dot menus from each item - it can cause confusion. i believe that is a bug?

[topotropic]

yes, please hide the 3-dot list item menus for history and bookmarks when in multi-select

[mcarare]

@lime124 Just to clarify: When an item is selected, we want to hide it's menu or menus for all items?

[topotropic]

@mcarare please hide all 3-dot menus when in selection mode

[sv-ohorvath]

Verified as fixed on Nightly 9/18.

[Lululalu]

@sv-ohorvath unfortunately it's not fixed for me. When I select an entry in the history list some entries still exhibit the menus.

[mcarare]

@Lululalu can you reproduce this also for Bookmarks, or it's just for History?

[sv-ohorvath]

@mcarare I can reproduce that on both bookmarks & history. You need to have a long list and some under the fold will still have the 3 dot button.
@Lululalu thanks, I didn't notice that!

[AndiAJ]

Hi, I've just checked on the latest Nightly Build #12870607 from 14/10 using the following devices :
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

There's still a minor inconsistency when selecting one or more items from the history list.
The 3 dot menu is displayed for one of the other (unselected) listed items.
On the other hand it seems to be disappearing after navigating through the list.

► Video One item selected

► Video Three items selected

@mcarare Please review the above the above mentioned matter. :)
I'll remove the QA needed label until further clarifications.

[boek]

@mcarare ^^ :)

[AndiAJ]

Hi, still reproducible on the latest Nightly Build #13250607 from 11/21 using the following devices:
• Google Pixel 3a XL (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Video

[mcarare]

For QA: Please test in next Nightly. Please note that the favicon blinking issue will be investigated and addressed in the future!

[softvision-miralobontiu]

Verified that the three-dot menus aren't displayed if one of the history listings is selected.
Tested with Huawei MediaPad M2 (Android 5.1.1), Google Pixel 3 (Android Q), and Nexus 5 (Android 6.0.1) on the latest Nightly build 191202.