Fenix: [Bug] Fenix Custom Tab support for start and exit animations

Created on 30 Apr 2019  路  7Comments  路  Source: mozilla-mobile/fenix

This is probably something to do with start and exit animations not being implemented properly in Fenix: https://developer.chrome.com/multidevice/android/customtabs#configure-custom%20enter%20and%20exit%20animations

See also video:

Steps to reproduce

  • Fenix as default browser
  • Load Gmail app
  • Open a link
  • Notice app transition

Expected behavior

  • Gmail app slides to the left and Fenix appears

Actual behavior

  • Fenix just appears on top (with a black flash, separate bug)

Device information

  • Android device: Samsung S10e
  • Fenix version: latest from playstore
CustomTabs P3 ac 馃悶 bug 馃檯 waiting

Most helpful comment

Do we want a different animation than what we have now? :)

According to Chrome's doc, app developers are allowed to customize the enter and exit animation to make it look more native: https://developer.chrome.com/multidevice/android/customtabs

All 7 comments

@boek @sblatz is this related to the start up issue #599? do we have animations already from amy or is this something new she needs to provide? the answer will dictate the next step for this issue. removing ux label.

Do we want a different animation than what we have now? :)

Here's our current animation:
demo of custom 2020-05-05 13_51_03

Do we want a different animation than what we have now? :)

According to Chrome's doc, app developers are allowed to customize the enter and exit animation to make it look more native: https://developer.chrome.com/multidevice/android/customtabs

Asking UX if we need a custom animation for custom tabs and what should that be.
Saw no animations in https://github.com/mozilla-mobile/fenix/issues/599.

To get the animations shown in the issue description Fennec uses simple slide right/left animations
Should we use the same?

On the engineering side, I definitely recommend supporting custom animations. I can definitely see this as something that could make some app developers decide to hard code Chrome's app id to their custom tabs (which would make the app always open Chrome instead of the default browser) which would be pretty bad.

Here's our current animation:
demo of custom 2020-05-05 13_51_03

Hi @sblatz - I don't see this animation when Fenix is set as default and I open links via email, slack, etc. It doesn't seem to be any animation and just appears. I'd be okay with the current animation you have here.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

CharmCityCrab picture CharmCityCrab  路  59Comments

Cheap-Skate picture Cheap-Skate  路  67Comments

Lorinet picture Lorinet  路  62Comments

dimqua picture dimqua  路  96Comments

djdisodo picture djdisodo  路  108Comments