Fenix: FNX-5345 ⁃ [Bug] Bookmark separators aren't handled well visually

[grigoryk]

See screenshot:

UNITO-UNDERSCORE!1556053116!

[colintheshots]

This has definitely improved visually from where it was. We can look at more improvements post-MVP.

[bifleming]

@colintheshots do you know if we still need UX help with this? @mheubusch

[mheubusch]

@AmyYLee another bookmark visual design issue - I think Colin is asking that you review and approve the current implementation or point back to the implementation checklist issues that still remain.

[AmyYLee]

Assigning to @topotropic since she worked on bookmarks.

[topotropic]

It looks better now, agreed.

If we want to improve this, we could remove the 3-dot menu which adds visual noise and since we don't support adding a separator we could also not support removing separators. Visually we would have a 1dp separator with 16dp spacing on each side. But, maybe let's ignore this for now and close the issue? @vesta0

[vesta0]

Thanks @topotropic ! Is this Eng ready or do we need @shorlander approval?

[topotropic]

Talked quickly to Stephen, it's alright.

Spec:

[softvision-miralobontiu]

Verified on a today debug build 1.0.1928 GV 68.0-20190612114833 with Motorola Moto G6 (Android 8), and Nexus 6 (Android 7.1.1).