Fenix: FNX-5291 ⁃ [Bug] Scattered Textviews in About Fenix

Created on 20 Apr 2019  ·  13Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

1- Go to settings.
2- Go to About Fenix
You'll notice some text views are not in center.

Expected behavior

These textviews should be centered.

Actual behavior

Not centered.

Device information

x86GreenFieldDebug
Galaxy Nexus API 24

GIF:

P2 ready 🐞 bug

All 13 comments

I have added a PR https://github.com/mozilla-mobile/fenix/pull/1861

Let me know if any changes are required.

@AmyYLee can you review? i'm not sure if Bram had a design for this screen.

Hi,

Can you please reference this mock for content placement. Thanks!

https://mozilla.invisionapp.com/share/AHRPCMCYD2Q

@jatinkumarg Please have a look at the link above @AmyYLee has given and make the changes accordingly.

@iadeelzafar Sure thing!

Hey, I am having issues with the build. So anyone who wants to fix it, please go ahead.

Hello, is the following text Fenix puts you in control completely removed from About Fenix? it's missing and I didn't saw any mention about it.
@vesta0 can you please clarify if this is intended?

@abodea I wasn't aware of this change. @mheubusch was this planned?

@softvision-miralobontiu can you please provide info on what is blocking this?

I'll remove the "blocked" flag. Sorry for the misunderstanding.

@mheubusch did we mean to remove "Fenix puts you in control" from the About Firefox Preview pag?

Yes. We don’t yet have an approved tag line from marketing so asked to remove this until we do.

On Jun 6, 2019, at 5:20 PM, Vesta Zare notifications@github.com wrote:

@mheubusch did we mean to remove "Fenix puts you in control" from the About Firefox Preview pag?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Closing this issue since the original reported bug has been resolved. A new issue can be opened for adding a new tagline once we have one.

Was this page helpful?
0 / 5 - 0 ratings