Fenix: FNX-5285 ⁃ [Bug] pressing back with open address bar should not close Fenix

[cadeyrn]

Steps to reproduce

1. open the adressbar
2. press the back key of your device

Expected behavior

You returns to the home screen of Fenix.

Actual behavior

Fenix is closed.

Device information

• Android device: HTC U11 / Android 8.0
• Fenix version: Fenix revision 080dadcb7e1cc0aa53c020595505f6f493e4a143

[cadeyrn]

The same applies for the QR code scanner: If you accidentally starts the QR code scanner and press back to close it Fenix closes instead of returning to either the open address bar or the Fenix home screen.

[vesta0]

I believe this is fixed.

[cadeyrn]

I believe this is fixed.

No, it's not fixed with latest version from master.

[sv-ohorvath]

I cannot reproduce the issue.
Devices: Pixel (Android 9) &HTC Desire 820 (Android 6.0.1).
Build: 4/24.
@cadeyrn Please check again and close if it's fixed for you too.

[cadeyrn]

Yes, it's still an issue. Sometimes Fenix does not close. But repeating the same closes Fenix every time.

I can make a screencast later today.

[cadeyrn]

Here is a screencast. After opening the address bar I press the back button of my device (HTC U11) and Fenix closes instead of returning to the Fenix home screen.

[kbrosnan]

You are each using a different entry point. Unclear where @cadeyrn is tapping but maybe it is the "Search or enter address". @sv-ohorvath is tapping on the plus button.

[kbrosnan]

I tried reproducing cadeyrn's results on a HTC U11+ HTC_2Q4D100 and was not able to reproduce.

[cadeyrn]

You are each using a different entry point. Unclear where @cadeyrn is tapping but maybe it is the "Search or enter address". @sv-ohorvath is tapping on the plus button.

Yes, I tapped "Search or enter address" but using the plus button doesn't make a difference.

Is there anything I can do to help debugging the issue?
I use local builds so it's no problem for me to add some logging or changes to try things if someone tells me what I should do.

[kbrosnan]

Would you try a taskcluster build? https://tools.taskcluster.net/index/project.mobile.fenix.signed-nightly.nightly.2019.4.26/latest

[cadeyrn]

Same issue with the taskcluster build.

Please note that sometimes it always happens but sometimes it works as expected so you have to test multiple times.

[bifleming]

@kbrosnan is this still blocked?

[cadeyrn]

I don't know what fixed it but I can no longer reproduce.

[cadeyrn]

For the record: This issue was fixed by the androidx dependencies update in #2350.