Fenix: FNX-2437 ⁃ Fenix should use Gecko's downloading streaming API instead of the Android manager
Steps to reproduce
- Visit https://ebookclub.tor.com/ and provide an email address to prove you've signed up (sorry, the download's behind an account. Maybe other downloads are similarly affected, I don't know.)
- Download the
.epubedition of Cory Doctorow's "Walkaway"
Expected behavior
- The download completes properly and is about 1.36MB in size.
(This is what happens when I do this with Firefox for Android Beta)
Actual behavior
- The download "completes" at 25.79KB, and is an invalid file
Device information
- Android device: Samsung Galaxy A5
- Fenix version: 1.0.1916 build#11051220 68.0a1-20190408104625
chutten
All 15 comments
If you poke at the file with a text editor is it something text based (html, etc) or binary?
kbrosnan
on 16 Apr 2019
*copies it off of the device*
Oh, look, it's the HTML of the download page. Interesting.
chutten
on 16 Apr 2019
@cpeterso does this sound like a GV bug and do we have one filed for it?
vesta0
on 16 Apr 2019
We have some Fennec bugs about file downloads, but I filed a new GV bug for this STR: https://bugzilla.mozilla.org/show_bug.cgi?id=1544955
cpeterso
on 16 Apr 2019
Could be caused by us not forwarding GV cookies to the download manager?
pocmo
on 17 Apr 2019
Could be caused by us not forwarding GV cookies to the download manager?
Yes. Fenix is using the Android download manager instead of Gecko and the Android download manager doesn't have the user cookies (as suggested in GV bug https://bugzilla.mozilla.org/show_bug.cgi?id=1476364).
@snorp thinks Fenix should use Gecko's downloading streaming API instead of the Android manager.
cpeterso
on 3 May 2019
Since we already removed the download icon from the Quick Action Bar, and if this proves challenging or time-consuming to implement, could we remove the ability to download files altogether for MVP? @vesta0 LMK if you think this is an option.
mheubusch
on 7 May 2019
@mheubusch I can't speak to how much engineering work it is to block Fenix from using Android download manager but my recommendation is to keep the basic download functionality (which still covers most use cases) until the GV API is ready.
vesta0
on 8 May 2019
I agree that it's probably best to leave this alone for MVP, but just wanted to clarify that the GV API is mostly ready. You need to make a second request (as Fenix does today), but it will use Gecko's cookies.
snorp
on 8 May 2019
Thanks @vesta0 - so this is just a use case where we need to supply credentials to a site before initiating the download? I think I understand better now. Thanks for updating the labels and lmk if we should move this out of the Fenix backlog altogether for MVP.
mheubusch
on 8 May 2019
The new gecko downloader is being tested in Reference Browser, when should we switch Fenix?
NotWoods
on 19 Jul 2019
Same issue here with download links for stack-storage. Example: https://wkursten.stackstorage.com/s/Y8hkexL8qDTXVVb. Android notification: <Untitled>
Download unsuccessful.
TjeuKayim
on 25 Jul 2019
Unfortunately this issue still happens. Downloading the 1.5MB ebook instead results in a 27KB file on disk.
chutten
on 12 Feb 2020
Fenix version: 200211 06:01 (build 20420611)
chutten
on 12 Feb 2020
kbrosnan points out that this is probably a dupe of #7531. Let's take it there.
chutten
on 12 Feb 2020
Related issues
abodea
·
3Comments
andreicristianpetcu
·
3Comments
andreicristianpetcu
·
3Comments
robsmith11
·
3Comments
csadilek
·
3Comments
Most helpful comment
@mheubusch I can't speak to how much engineering work it is to block Fenix from using Android download manager but my recommendation is to keep the basic download functionality (which still covers most use cases) until the GV API is ready.