Fenix: Home overflow menus don't inflate up when towards bottom of the screen

[sv-ohorvath]

Steps to reproduce

1. Turn the device in landscape mode.
2. Open a session's overflow menu.
   

   Expected behavior

The menu is displayed above the fold.

Actual behavior

The menu is displayed under the fold, you have to pull it up to see it. Scrolling the page down doesn't work.
Turning the device to portrait mode, the session title will disappear.

Device information

• Android device: Pixel (Android 9), Nexus 5(Android 6)
• Fenix version: master build 3/13.

[jatinkumarg]

Hey, just want to add more info about this bug. For me, on my device, it also removes the Archive button whenever I switch from portrait to landscape or vice versa

Potrait

Landscape

[topotropic]

We got rid of this menu view with introduction of the new Collections features but if you tap on the overflow menu now it still renders below the fold.

[sblatz]

@topotropic can you clarify what you mean?

I'm not able to reproduce this bug.

[topotropic]

See screenshot but I guess that's a rare case

[sblatz]

This is actually blocked on https://github.com/mozilla-mobile/android-components/issues/2916.

@vesta0, @bifleming can we get that a-c ticket properly prioritized?

[Amejia481]

@sblatz We could detect when the phone is in landscape and use if so pass an up orientation. Could this be an alternative?
orientation = BrowserMenu.Orientation.UP

. Could this be an alternative?

[softvision-miralobontiu]

This is not fixed yet. The menu is not entirely visible, it is scrollable though - please see the attached screenshot.
Tested with the latest build 1,0,1924 (#11630619), with OnePlus 5T (Android 9), Motorola Nexus 6 (Android 7,1,1).

[Amejia481]

I think this is a different issue from the original one. This only happens after the menu is opened on portrait mode, and while is open the phone is switched to landscape mode.

[softvision-miralobontiu]

Arturo, the same behavior is when opening that menu directly in landscape mode.

[sblatz]

I agree with @Amejia481 this seems like a separate issue. When I open the menu in landscape, it properly inflates upwards:

@softvision-miralobontiu are you not seeing the menu inflate upwards in landscape?

I can file the rotation issue as a separate ticket :)

[sblatz]

Follow up issue filed at https://github.com/mozilla-mobile/fenix/issues/3390

[softvision-miralobontiu]

@sblatz in landscape the menu inflates, as you've mentioned.

I will close this as fixed.