Fenix: Add ability to disable all suggestion providers

Created on 12 Mar 2019  路  13Comments  路  Source: mozilla-mobile/fenix

Why/User Benefit/User Problem

I may not want to expose my clipboard, nor search my history (which tends to be rather crowded). It'd be great if we had a toggle to just disable all (or on a per provider basis) the suggestion providers of AwesomeBar.

Acceptance Criteria (how do I know when I鈥檓 done?)

Users have the ability to toggle on/off which suggestion providers they want to use.

InVision: https://mozilla.invisionapp.com/share/M4SBYCLJPQG#/365634921_Settings_-_Search_Alt

E3 Search engverified ready s

Most helpful comment

I suggest creating a separate toggle for each type of suggestion (history, bookmarks)

We already have a toggle to turn off search provider suggestions.

All 13 comments

_Note: this would be pretty small engineering effort due to the way these are implemented_

We have largely done this with the options in the search suggestion settings. Is there any other part that is blocking this @sblatz?

@kbrosnan this is mainly a UX/product decision on if or how we want to do this. It'd be easy to add toggles for each type of suggestion in the search settings menu and allow users to enable as they'd prefer.

I suggest creating a separate toggle for each type of suggestion (history, bookmarks)

We already have a toggle to turn off search provider suggestions.

removing the ux label - this is on our radar already as it's part of Q3 plans.

@vesta0 @sblatz InVision link added to AC above, please let me know if you have any feedback.

Thanks @apbitner :)

@jpfaller would you please review/approve the copy?

Copy has been updated in the Invision.

If this has designs/copy should we label as eng-ready so we can size in a future sprint?

@apbitner Are we able to add a toggle for hiding clipboard suggestions as well? This was a big reason for the creation of this ticket and was frequently requested by users.

We'll want copy for this too. @jpfaller.

Perhaps something like: "Show clipboard suggestion"

Ah, I was going off of @vesta0 's comment on Jul 2 that mentioned history and bookmarks. Let's add a third toggle then, pending copy.

Show clipboard suggestions

@apbitner

Verified on Nightly 9/9. Devices: Google Pixel 3 (Android 9), HTC Desire 820 (Android 6.0.1)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

robsmith11 picture robsmith11  路  3Comments

thelazyoxymoron picture thelazyoxymoron  路  3Comments

clitetailor picture clitetailor  路  3Comments

andreicristianpetcu picture andreicristianpetcu  路  3Comments

topotropic picture topotropic  路  3Comments