Fenix: FNX2-16573 ⁃ [Meta] Browser UI + 3 Dot Menu

Created on 6 Dec 2018  ·  9Comments  ·  Source: mozilla-mobile/fenix

  • URL bar at the bottom, door hanger, home icon, menu
  • URL collapses
  • Swipe up/down to enable/disable Quick action menu
  • Include icons of quick action menu (UI only)
  • Menu (Help, Settings, Your Library, etc.)
  • Talk back implementation

Android components:

  • menu component
  • toolbar component

Open questions:

  • decide if we should show URL vs title
  • GV dependency: resizing web content when you scroll

  • [ ] UI containing the browser and toolbar (#131)
  • [ ] URL bar triggers search (#132)
  • [ ] Menu button (#133)
  • [ ] Collapsing toolbar (#134)
  • [ ] a11y (#135)
  • [ ] Show URL icon (favicon)
MainMenu Toolbar a11y ready ac

Most helpful comment

Our security team probably won't approve this: if displaying title, the risk of spoofing is very high: title is site owner controlled, while domain is something verifiable, e.g. anyone can call their site "Citibank", but there's only one citibank.com

All 9 comments

  • [x] UI containing the browser and toolbar (#131)
  • [x] URL bar triggers search (#132)
  • [x] Menu button (#133)
  • [x] Collapsing toolbar (#134)
  • [x] a11y (#135)

decide if we should show URL vs title

The address bar should never show title or favicon.

Neither of those provide any accurate, verifiable information as they are user-generated content, phishers would love to write anything there. It takes away the user freedom of seeing what page are you on, keeping only the way the web developer wants to represent it.

Better yet, I would recommend using the address bar of Firefox Lite as it is smaller and therefore fits more of the address.

Please use the URL. Showing the title is super friendly to phishing.

Our security team probably won't approve this: if displaying title, the risk of spoofing is very high: title is site owner controlled, while domain is something verifiable, e.g. anyone can call their site "Citibank", but there's only one citibank.com

betty made do this

@lime124 and @bifleming I am closing this meta as all the related user stories have been completed.

Engineering - please review the items on this spreadsheet - this is a punchlist showing fit and finish issues blocking feature completeness.
https://docs.google.com/spreadsheets/d/15c-w-5zJ07WIkhWkb-LwhkGC-229yzKE7VbuMsPvZAM/edit?usp=sharing

Was this page helpful?
0 / 5 - 0 ratings