When searching for "other pages" in fec.gov, the search generally yields badly outdated results pointing to transition pages that no longer exist.
For example, a search in fec.gov's search box for "Guideline good order public funding" should return the public funding page (https://www.fec.gov/introduction-campaign-finance/understanding-ways-support-federal-candidates/presidential-elections/public-funding-presidential-elections/) at the top. Instead this is the result. The correct page does not appear in the results.

(The correct page is actually at the top of google's results when searching the same term.)
The search should return updated results so that the latest version of the current pages appears. I don't think this is an SEO issue as noted above; fec.gov pages generally turn up in google's results quickly.
fec.gov content pages that have been taken down off of transition are returned in the search results. Pages that have been up for quite awhile and are in the results for the same term searched in Google do not.
_List any steps you took for this issue to happen. Be sure to include the URL and what you clicked or entered._
URL: https://www.fec.gov/…
Same search on Google, yielding correct page as top result:

This is actually happening a lot with various searches for content pages, but this was the most egregious error yet, as public funding page has been up for over a year.
Completion criteria:
The overall site search doesn't include latest updates.
If you want to search anything from latest updates, search in the separate search box for that.
The overall site search will look through certain data search aspects (committee name, contributor name, candidate name, etc. and text from legal resources (but not from legal resources data results, like AOs, etc.)
While we're reindexing the site, I'd like to think about adding a sitemap.xml. Are there places in the site that people are having trouble finding, places we'd like them to find more easily, etc? May be good to add those to a general sitemap so search engines can more readily find them.
Trying to get access into the rebranded search.gov system. Emailed the system owner yesterday. Going to move this to blocked, it's important that we get access back into the system before we start trying to re-index. Need to verify the API key from their system is also still valid.
I have received a response back from the search.gov team and I have access back into their system now. Heading back into researching this ticket.
Found some great documentation on our website's search indexing here: https://github.com/fecgov/fec-cms/blob/develop/fec/search/management/instructions.md
I was able to follow the documentation to re-index the wagtail pages and data app pages. Next we'll need to re-index transition pages.
@dorothyyeager The pages for transition are scraped based on the pages that are defined in this JSON file: https://github.com/fecgov/fec-cms/blob/develop/fec/search/management/data/transition_pages.json. Is there a more up-to-date list of transition pages you would like me to scrape? It doesn't have to be every page on transition, just the pages we think are important to have in the search.
Thanks for checking @patphongs Most of those pages in that file have been removed from transition and/or redirected. Here's what can be deleted from the scrape because we have Wagtail pages for them (so in other words, this is the list of pages not to scrape for search).
http://transition.fec.gov/pubrec/publicrecordsoffice.shtml#using
http://transition.fec.gov/info/hearings.shtml
http://transition.fec.gov/af/AFPRegulations.shtml
http://transition.fec.gov/elecfil/electron.shtml
http://transition.fec.gov/info/forms.shtml
http://transition.fec.gov/info/ElectionDate/
http://transition.fec.gov/info/publications.shtml
http://transition.fec.gov/pages/bcra/bcra_update.shtml
http://transition.fec.gov/info/outreach.shtml and any anchor links to that page
http://transition.fec.gov/info/elearning.shtml
http://transition.fec.gov/ans/answers.shtml
http://transition.fec.gov/ans/answers_general.shtml
http://transition.fec.gov/ans/answers_disclosure.shtml
http://transition.fec.gov/ans/answers_compliance.shtml
http://transition.fec.gov/ans/answers_filing.shtml
http://transition.fec.gov/ans/answers_candidate.shtml
http://transition.fec.gov/ans/answers_pac.shtml
http://transition.fec.gov/ans/answers_party.shtml
http://transition.fec.gov/ans/answers_public_funding.shtml
Thanks @dorothyyeager! These have been removed from the site search. At some point, I'd like the content team to decide what pages on the transition site should be added to the site index. Made a new ticket here: https://github.com/fecgov/fec-cms/issues/3279
Thanks for doing this! It will be awesome to have all the content we've been putting up show up in the searches. Much, much appreciated! Will start thinking about the new ticket.
While we're reindexing the site, I'd like to think about adding a sitemap.xml. Are there places in the site that people are having trouble finding, places we'd like them to find more easily, etc? May be good to add those to a general sitemap so search engines can more readily find them.
Thank you @rfultz for suggesting this! I wrote up a ticket that explains steps that should be taken to accomplish this goal: https://github.com/fecgov/fec-cms/issues/3280. It may even help us with automating search indexing from search.gov.
@dorothyyeager I noticed that your example in this issue is still not showing up in the site search. I think it's not indexing the children or descendants of this section: /introduction-campaign-finance/. It may be missing other pages too. I created this new issue to see if we can figure out why: https://github.com/fecgov/fec-cms/issues/3281
@dorothyyeager FYI, solved the issue about the /introduction-campaign-finance/ page indexing. It now appears in the search. Still going to leave open #3281 though, in case there's others we want to add to the index.
Thanks @patphongs !! Good idea. I'll think on it.